summaryrefslogtreecommitdiff
path: root/cli/tests/unit_node/console_test.ts
diff options
context:
space:
mode:
authorKenta Moriuchi <moriken@kimamass.com>2024-01-04 13:12:38 +0900
committerGitHub <noreply@github.com>2024-01-04 09:42:38 +0530
commitb2cd254c35b6b1b128beea0eacdb8e814d91e003 (patch)
treed55fa5910e32d8a664aff5b680e07debea93181e /cli/tests/unit_node/console_test.ts
parent48556748577ba46db5f9212d14a0fcaa90d632f6 (diff)
fix: strict type check for cross realms (#21669)
Deno v1.39 introduces `vm.runInNewContext`. This may cause problems when using `Object.prototype.isPrototypeOf` to check built-in types. ```js import vm from "node:vm"; const err = new Error(); const crossErr = vm.runInNewContext(`new Error()`); console.assert( !(crossErr instanceof Error) ); console.assert( Object.getPrototypeOf(err) !== Object.getPrototypeOf(crossErr) ); ``` This PR changes to check using internal slots solves them. --- current: ``` > import vm from "node:vm"; undefined > vm.runInNewContext(`new Error("message")`) Error {} > vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`) Date {} ``` this PR: ``` > import vm from "node:vm"; undefined > vm.runInNewContext(`new Error("message")`) Error: message at <anonymous>:1:1 > vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`) 2018-12-10T02:26:59.002Z ``` --------- Co-authored-by: Bartek IwaƄczuk <biwanczuk@gmail.com>
Diffstat (limited to 'cli/tests/unit_node/console_test.ts')
-rw-r--r--cli/tests/unit_node/console_test.ts28
1 files changed, 28 insertions, 0 deletions
diff --git a/cli/tests/unit_node/console_test.ts b/cli/tests/unit_node/console_test.ts
new file mode 100644
index 000000000..583e98e22
--- /dev/null
+++ b/cli/tests/unit_node/console_test.ts
@@ -0,0 +1,28 @@
+// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
+
+import vm from "node:vm";
+import { stripColor } from "../../../test_util/std/fmt/colors.ts";
+import { assertStringIncludes } from "../../../test_util/std/assert/mod.ts";
+
+Deno.test(function inspectCrossRealmObjects() {
+ assertStringIncludes(
+ stripColor(
+ Deno.inspect(vm.runInNewContext(`new Error("This is an error")`)),
+ ),
+ "Error: This is an error",
+ );
+ assertStringIncludes(
+ stripColor(
+ Deno.inspect(
+ vm.runInNewContext(`new AggregateError([], "This is an error")`),
+ ),
+ ),
+ "AggregateError: This is an error",
+ );
+ assertStringIncludes(
+ stripColor(
+ Deno.inspect(vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`)),
+ ),
+ "2018-12-10T02:26:59.002Z",
+ );
+});