From b2cd254c35b6b1b128beea0eacdb8e814d91e003 Mon Sep 17 00:00:00 2001 From: Kenta Moriuchi Date: Thu, 4 Jan 2024 13:12:38 +0900 Subject: fix: strict type check for cross realms (#21669) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Deno v1.39 introduces `vm.runInNewContext`. This may cause problems when using `Object.prototype.isPrototypeOf` to check built-in types. ```js import vm from "node:vm"; const err = new Error(); const crossErr = vm.runInNewContext(`new Error()`); console.assert( !(crossErr instanceof Error) ); console.assert( Object.getPrototypeOf(err) !== Object.getPrototypeOf(crossErr) ); ``` This PR changes to check using internal slots solves them. --- current: ``` > import vm from "node:vm"; undefined > vm.runInNewContext(`new Error("message")`) Error {} > vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`) Date {} ``` this PR: ``` > import vm from "node:vm"; undefined > vm.runInNewContext(`new Error("message")`) Error: message at :1:1 > vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`) 2018-12-10T02:26:59.002Z ``` --------- Co-authored-by: Bartek Iwańczuk --- cli/tests/unit_node/console_test.ts | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 cli/tests/unit_node/console_test.ts (limited to 'cli/tests/unit_node/console_test.ts') diff --git a/cli/tests/unit_node/console_test.ts b/cli/tests/unit_node/console_test.ts new file mode 100644 index 000000000..583e98e22 --- /dev/null +++ b/cli/tests/unit_node/console_test.ts @@ -0,0 +1,28 @@ +// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license. + +import vm from "node:vm"; +import { stripColor } from "../../../test_util/std/fmt/colors.ts"; +import { assertStringIncludes } from "../../../test_util/std/assert/mod.ts"; + +Deno.test(function inspectCrossRealmObjects() { + assertStringIncludes( + stripColor( + Deno.inspect(vm.runInNewContext(`new Error("This is an error")`)), + ), + "Error: This is an error", + ); + assertStringIncludes( + stripColor( + Deno.inspect( + vm.runInNewContext(`new AggregateError([], "This is an error")`), + ), + ), + "AggregateError: This is an error", + ); + assertStringIncludes( + stripColor( + Deno.inspect(vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`)), + ), + "2018-12-10T02:26:59.002Z", + ); +}); -- cgit v1.2.3