diff options
author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2020-03-19 00:25:55 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-03-18 19:25:55 -0400 |
commit | 6e2df8c64feb92653077a5494d2c64a9f6fd2f48 (patch) | |
tree | d359310f24622ef38b57538fcdc698f6cadb620d /std/fs/empty_dir_test.ts | |
parent | 070464e2cc617ecbd2c63dc5c4ac0432a77a29fd (diff) |
feat: Deno.test() sanitizes ops and resources (#4399)
This PR brings assertOps and assertResources sanitizers to Deno.test() API.
assertOps checks that test doesn't leak async ops, ie. there are no unresolved
promises originating from Deno APIs. Enabled by default, can be disabled using
Deno.TestDefinition.disableOpSanitizer.
assertResources checks that test doesn't leak resources, ie. all resources used
in test are closed. For example; if a file is opened during a test case it must be
explicitly closed before test case finishes. It's most useful for asynchronous
generators. Enabled by default, can be disabled using
Deno.TestDefinition.disableResourceSanitizer.
We've used those sanitizers in internal runtime tests and it proved very useful in
surfacing incorrect tests which resulted in interference between the tests.
All tests have been sanitized.
Closes #4208
Diffstat (limited to 'std/fs/empty_dir_test.ts')
-rw-r--r-- | std/fs/empty_dir_test.ts | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/std/fs/empty_dir_test.ts b/std/fs/empty_dir_test.ts index 8f9ca72c3..553d63001 100644 --- a/std/fs/empty_dir_test.ts +++ b/std/fs/empty_dir_test.ts @@ -23,7 +23,7 @@ Deno.test(async function emptyDirIfItNotExist(): Promise<void> { assertEquals(stat.isDirectory(), true); } finally { // remove the test dir - Deno.remove(testDir, { recursive: true }); + await Deno.remove(testDir, { recursive: true }); } }); @@ -39,7 +39,7 @@ Deno.test(function emptyDirSyncIfItNotExist(): void { assertEquals(stat.isDirectory(), true); } finally { // remove the test dir - Deno.remove(testDir, { recursive: true }); + Deno.removeSync(testDir, { recursive: true }); } }); @@ -218,16 +218,15 @@ for (const s of scenes) { ); args.push("testfolder"); - const { stdout } = Deno.run({ + const p = Deno.run({ stdout: "piped", cwd: testdataDir, args: args }); - assert(stdout); - - const output = await Deno.readAll(stdout); - + assert(p.stdout); + const output = await p.output(); + p.close(); assertStrContains(new TextDecoder().decode(output), s.output); } catch (err) { await Deno.remove(testfolder, { recursive: true }); |