feat: Deno.test() sanitizes ops and resources (#4399)

This PR brings assertOps and assertResources sanitizers to Deno.test() API.

assertOps checks that test doesn't leak async ops, ie. there are no unresolved
promises originating from Deno APIs. Enabled by default, can be disabled using 
Deno.TestDefinition.disableOpSanitizer.

assertResources checks that test doesn't leak resources, ie. all resources used
in test are closed. For example; if a file is opened during a test case it must be
explicitly closed before test case finishes. It's most useful for asynchronous
generators. Enabled by default, can be disabled using 
Deno.TestDefinition.disableResourceSanitizer.

We've used those sanitizers in internal runtime tests and it proved very useful in
surfacing incorrect tests which resulted in interference between the tests.

All tests have been sanitized.

Closes #4208

5 files changed, 15 insertions, 14 deletions

diff --git a/std/fs/empty_dir_test.ts b/std/fs/empty_dir_test.ts
index 8f9ca72c3..553d63001 100644
--- a/std/fs/empty_dir_test.ts
+++ b/std/fs/empty_dir_test.ts
@@ -23,7 +23,7 @@ Deno.test(async function emptyDirIfItNotExist(): Promise<void> {
     assertEquals(stat.isDirectory(), true);
   } finally {
     // remove the test dir
-    Deno.remove(testDir, { recursive: true });
+    await Deno.remove(testDir, { recursive: true });
   }
 });
 
@@ -39,7 +39,7 @@ Deno.test(function emptyDirSyncIfItNotExist(): void {
     assertEquals(stat.isDirectory(), true);
   } finally {
     // remove the test dir
-    Deno.remove(testDir, { recursive: true });
+    Deno.removeSync(testDir, { recursive: true });
   }
 });
 
@@ -218,16 +218,15 @@ for (const s of scenes) {
         );
         args.push("testfolder");
 
-        const { stdout } = Deno.run({
+        const p = Deno.run({
           stdout: "piped",
           cwd: testdataDir,
           args: args
         });
 
-        assert(stdout);
-
-        const output = await Deno.readAll(stdout);
-
+        assert(p.stdout);
+        const output = await p.output();
+        p.close();
         assertStrContains(new TextDecoder().decode(output), s.output);
       } catch (err) {
         await Deno.remove(testfolder, { recursive: true });
diff --git a/std/fs/ensure_symlink_test.ts b/std/fs/ensure_symlink_test.ts
index 8017bcebf..2357650ab 100644
--- a/std/fs/ensure_symlink_test.ts
+++ b/std/fs/ensure_symlink_test.ts
@@ -15,13 +15,13 @@ Deno.test(async function ensureSymlinkIfItNotExist(): Promise<void> {
   const testDir = path.join(testdataDir, "link_file_1");
   const testFile = path.join(testDir, "test.txt");
 
-  assertThrowsAsync(
+  await assertThrowsAsync(
     async (): Promise<void> => {
       await ensureSymlink(testFile, path.join(testDir, "test1.txt"));
     }
   );
 
-  assertThrowsAsync(
+  await assertThrowsAsync(
     async (): Promise<void> => {
       await Deno.stat(testFile).then((): void => {
         throw new Error("test file should exists.");
diff --git a/std/fs/exists_test.ts b/std/fs/exists_test.ts
index 0a1293d96..4202f2734 100644
--- a/std/fs/exists_test.ts
+++ b/std/fs/exists_test.ts
@@ -121,14 +121,14 @@ for (const s of scenes) {
     args.push(path.join(testdataDir, s.async ? "exists.ts" : "exists_sync.ts"));
     args.push(s.file);
 
-    const { stdout } = Deno.run({
+    const p = Deno.run({
       stdout: "piped",
       cwd: testdataDir,
       args: args
     });
 
-    const output = await Deno.readAll(stdout!);
-
+    const output = await p.output();
+    p.close();
     assertStrContains(new TextDecoder().decode(output), s.output);
   });
   // done
diff --git a/std/fs/expand_glob_test.ts b/std/fs/expand_glob_test.ts
index 58da2c1bf..6bdb77266 100644
--- a/std/fs/expand_glob_test.ts
+++ b/std/fs/expand_glob_test.ts
@@ -131,4 +131,5 @@ Deno.test(async function expandGlobPermError(): Promise<void> {
     decode(await p.stderrOutput()),
     "Uncaught PermissionDenied"
   );
+  p.close();
 });
diff --git a/std/fs/walk_test.ts b/std/fs/walk_test.ts
index 91cfd57c8..07f846b49 100644
--- a/std/fs/walk_test.ts
+++ b/std/fs/walk_test.ts
@@ -20,7 +20,7 @@ export async function testWalk(
       await t();
     } finally {
       chdir(origCwd);
-      remove(d, { recursive: true });
+      await remove(d, { recursive: true });
     }
   }
   Deno.test({ skip, name: `[walk] ${name}`, fn });
@@ -46,7 +46,8 @@ export async function walkArray(
 }
 
 export async function touch(path: string): Promise<void> {
-  await open(path, "w");
+  const f = await open(path, "w");
+  f.close();
 }
 
 function assertReady(expectedLength: number): void {