diff options
| author | Divy Srivastava <dj.srivastava23@gmail.com> | 2023-03-31 21:28:21 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-31 21:28:21 +0530 |
| commit | aa9b94a80eadde7737417eb7d412559bc567c77c (patch) | |
| tree | 14691957c663ad9d6c18ce837823f46e4ddc4347 /ext/websocket | |
| parent | feab94ff512987a9a7e01f41d7a1788712b4247c (diff) | |
perf(ext/websocket): use opAsync2 to avoid spread deopt (#18525)
This commit adds a new core API `opAsync2` to call an async op with
atmost 2 arguments. Spread argument iterators has a pretty big perf hit
when calling ops.
| name | avg msg/sec/core |
| --- | --- |
| 1.32.1 | `127820.750000` |
| #18506 | `140079.000000` |
| #18506 + #18509 | `150104.250000` |
| #18506 + #18509 + this | `157340.000000` |
Diffstat (limited to 'ext/websocket')
| -rw-r--r-- | ext/websocket/01_websocket.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ext/websocket/01_websocket.js b/ext/websocket/01_websocket.js index 03a6427c2..cadd35a50 100644 --- a/ext/websocket/01_websocket.js +++ b/ext/websocket/01_websocket.js @@ -301,7 +301,7 @@ class WebSocket extends EventTarget { const sendTypedArray = (ta) => { this[_bufferedAmount] += ta.byteLength; PromisePrototypeThen( - core.opAsync("op_ws_send_binary", this[_rid], ta), + core.opAsync2("op_ws_send_binary", this[_rid], ta), () => { this[_bufferedAmount] -= ta.byteLength; }, @@ -322,7 +322,7 @@ class WebSocket extends EventTarget { const d = core.encode(string); this[_bufferedAmount] += d.byteLength; PromisePrototypeThen( - core.opAsync("op_ws_send_text", this[_rid], string), + core.opAsync2("op_ws_send_text", this[_rid], string), () => { this[_bufferedAmount] -= d.byteLength; }, @@ -394,7 +394,7 @@ class WebSocket extends EventTarget { async [_eventLoop]() { while (this[_readyState] !== CLOSED) { - const { 0: kind, 1: value } = await core.opAsync( + const { 0: kind, 1: value } = await core.opAsync2( "op_ws_next_event", this[_rid], ); |