summaryrefslogtreecommitdiff
path: root/ext
diff options
context:
space:
mode:
authorDivy Srivastava <dj.srivastava23@gmail.com>2023-03-31 21:28:21 +0530
committerGitHub <noreply@github.com>2023-03-31 21:28:21 +0530
commitaa9b94a80eadde7737417eb7d412559bc567c77c (patch)
tree14691957c663ad9d6c18ce837823f46e4ddc4347 /ext
parentfeab94ff512987a9a7e01f41d7a1788712b4247c (diff)
perf(ext/websocket): use opAsync2 to avoid spread deopt (#18525)
This commit adds a new core API `opAsync2` to call an async op with atmost 2 arguments. Spread argument iterators has a pretty big perf hit when calling ops. | name | avg msg/sec/core | | --- | --- | | 1.32.1 | `127820.750000` | | #18506 | `140079.000000` | | #18506 + #18509 | `150104.250000` | | #18506 + #18509 + this | `157340.000000` |
Diffstat (limited to 'ext')
-rw-r--r--ext/fs/30_fs.js12
-rw-r--r--ext/http/01_http.js2
-rw-r--r--ext/node/polyfills/internal/crypto/random.ts2
-rw-r--r--ext/web/02_timers.js2
-rw-r--r--ext/websocket/01_websocket.js6
5 files changed, 12 insertions, 12 deletions
diff --git a/ext/fs/30_fs.js b/ext/fs/30_fs.js
index a8ae7ad3a..500416980 100644
--- a/ext/fs/30_fs.js
+++ b/ext/fs/30_fs.js
@@ -31,7 +31,7 @@ function chmodSync(path, mode) {
}
async function chmod(path, mode) {
- await core.opAsync("op_chmod_async", pathFromURL(path), mode);
+ await core.opAsync2("op_chmod_async", pathFromURL(path), mode);
}
function chownSync(
@@ -121,7 +121,7 @@ async function mkdir(
path,
options,
) {
- await core.opAsync("op_mkdir_async", mkdirArgs(path, options));
+ await core.opAsync2("op_mkdir_async", mkdirArgs(path, options));
}
function readDirSync(path) {
@@ -349,7 +349,7 @@ function ftruncateSync(rid, len) {
}
async function ftruncate(rid, len) {
- await core.opAsync("op_ftruncate_async", rid, coerceLen(len));
+ await core.opAsync2("op_ftruncate_async", rid, coerceLen(len));
}
function truncateSync(path, len) {
@@ -357,7 +357,7 @@ function truncateSync(path, len) {
}
async function truncate(path, len) {
- await core.opAsync("op_truncate_async", path, coerceLen(len));
+ await core.opAsync2("op_truncate_async", path, coerceLen(len));
}
function umask(mask) {
@@ -369,7 +369,7 @@ function linkSync(oldpath, newpath) {
}
async function link(oldpath, newpath) {
- await core.opAsync("op_link_async", oldpath, newpath);
+ await core.opAsync2("op_link_async", oldpath, newpath);
}
function toUnixTimeFromEpoch(value) {
@@ -499,7 +499,7 @@ function flockSync(rid, exclusive) {
}
async function flock(rid, exclusive) {
- await core.opAsync("op_flock_async", rid, exclusive === true);
+ await core.opAsync2("op_flock_async", rid, exclusive === true);
}
function funlockSync(rid) {
diff --git a/ext/http/01_http.js b/ext/http/01_http.js
index 7e648017b..5b78bb2f2 100644
--- a/ext/http/01_http.js
+++ b/ext/http/01_http.js
@@ -316,7 +316,7 @@ function createRespondWith(
break;
}
try {
- await core.opAsync("op_http_write", streamRid, value);
+ await core.opAsync2("op_http_write", streamRid, value);
} catch (error) {
const connError = httpConn[connErrorSymbol];
if (
diff --git a/ext/node/polyfills/internal/crypto/random.ts b/ext/node/polyfills/internal/crypto/random.ts
index 07d91976a..04678b6be 100644
--- a/ext/node/polyfills/internal/crypto/random.ts
+++ b/ext/node/polyfills/internal/crypto/random.ts
@@ -92,7 +92,7 @@ export function checkPrime(
);
}
- core.opAsync(op, candidate, checks).then(
+ core.opAsync2(op, candidate, checks).then(
(result) => {
callback?.(null, result);
},
diff --git a/ext/web/02_timers.js b/ext/web/02_timers.js
index 9bf41316a..c224be884 100644
--- a/ext/web/02_timers.js
+++ b/ext/web/02_timers.js
@@ -215,7 +215,7 @@ const scheduledTimers = { head: null, tail: null };
*/
function runAfterTimeout(cb, millis, timerInfo) {
const cancelRid = timerInfo.cancelRid;
- const sleepPromise = core.opAsync("op_sleep", millis, cancelRid);
+ const sleepPromise = core.opAsync2("op_sleep", millis, cancelRid);
timerInfo.promiseId = sleepPromise[SymbolFor("Deno.core.internalPromiseId")];
if (!timerInfo.isRef) {
core.unrefOp(timerInfo.promiseId);
diff --git a/ext/websocket/01_websocket.js b/ext/websocket/01_websocket.js
index 03a6427c2..cadd35a50 100644
--- a/ext/websocket/01_websocket.js
+++ b/ext/websocket/01_websocket.js
@@ -301,7 +301,7 @@ class WebSocket extends EventTarget {
const sendTypedArray = (ta) => {
this[_bufferedAmount] += ta.byteLength;
PromisePrototypeThen(
- core.opAsync("op_ws_send_binary", this[_rid], ta),
+ core.opAsync2("op_ws_send_binary", this[_rid], ta),
() => {
this[_bufferedAmount] -= ta.byteLength;
},
@@ -322,7 +322,7 @@ class WebSocket extends EventTarget {
const d = core.encode(string);
this[_bufferedAmount] += d.byteLength;
PromisePrototypeThen(
- core.opAsync("op_ws_send_text", this[_rid], string),
+ core.opAsync2("op_ws_send_text", this[_rid], string),
() => {
this[_bufferedAmount] -= d.byteLength;
},
@@ -394,7 +394,7 @@ class WebSocket extends EventTarget {
async [_eventLoop]() {
while (this[_readyState] !== CLOSED) {
- const { 0: kind, 1: value } = await core.opAsync(
+ const { 0: kind, 1: value } = await core.opAsync2(
"op_ws_next_event",
this[_rid],
);