diff options
| author | Matt Mastracci <matthew@mastracci.com> | 2023-03-23 16:00:46 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-23 16:00:46 -0600 |
| commit | ad77ba0f7b40760e04b79d9789da16d7c49010b8 (patch) | |
| tree | 557e87fb172dc034c1b0c0a36a0d824036a1f986 /ext/node/polyfills/internal/cli_table.ts | |
| parent | e8348231df2d2716e9e7ffb85340b773ff58a2f2 (diff) | |
fix(core): panic at build time if extension code contains anything other than 7-bit ASCII (#18372)
This will improve diagnostics and catch any non-ASCII extension code
early.
This will use `debug_assert!` rather than `assert!` to avoid runtime
costs, and ensures (in debug_assert mode only) that all extension source
files are ASCII as we load them.
Diffstat (limited to 'ext/node/polyfills/internal/cli_table.ts')
| -rw-r--r-- | ext/node/polyfills/internal/cli_table.ts | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/ext/node/polyfills/internal/cli_table.ts b/ext/node/polyfills/internal/cli_table.ts index a3740d889..b3523fffa 100644 --- a/ext/node/polyfills/internal/cli_table.ts +++ b/ext/node/polyfills/internal/cli_table.ts @@ -3,11 +3,6 @@ import { getStringWidth } from "ext:deno_node/internal/util/inspect.mjs"; -// The use of Unicode characters below is the only non-comment use of non-ASCII -// Unicode characters in Node.js built-in modules. If they are ever removed or -// rewritten with \u escapes, then a test will need to be (re-)added to Node.js -// core to verify that Unicode characters work in built-ins. -// Refs: https://github.com/nodejs/node/issues/10673 const tableChars = { middleMiddle: "\u2500", rowMiddle: "\u253c", |