From ad77ba0f7b40760e04b79d9789da16d7c49010b8 Mon Sep 17 00:00:00 2001 From: Matt Mastracci Date: Thu, 23 Mar 2023 16:00:46 -0600 Subject: fix(core): panic at build time if extension code contains anything other than 7-bit ASCII (#18372) This will improve diagnostics and catch any non-ASCII extension code early. This will use `debug_assert!` rather than `assert!` to avoid runtime costs, and ensures (in debug_assert mode only) that all extension source files are ASCII as we load them. --- ext/node/polyfills/internal/cli_table.ts | 5 ----- 1 file changed, 5 deletions(-) (limited to 'ext/node/polyfills/internal/cli_table.ts') diff --git a/ext/node/polyfills/internal/cli_table.ts b/ext/node/polyfills/internal/cli_table.ts index a3740d889..b3523fffa 100644 --- a/ext/node/polyfills/internal/cli_table.ts +++ b/ext/node/polyfills/internal/cli_table.ts @@ -3,11 +3,6 @@ import { getStringWidth } from "ext:deno_node/internal/util/inspect.mjs"; -// The use of Unicode characters below is the only non-comment use of non-ASCII -// Unicode characters in Node.js built-in modules. If they are ever removed or -// rewritten with \u escapes, then a test will need to be (re-)added to Node.js -// core to verify that Unicode characters work in built-ins. -// Refs: https://github.com/nodejs/node/issues/10673 const tableChars = { middleMiddle: "\u2500", rowMiddle: "\u253c", -- cgit v1.2.3