diff options
| author | Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> | 2024-03-11 15:49:43 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-11 15:49:43 -0700 |
| commit | a77b2987bc90879af30a39ba274df9061cc7fbae (patch) | |
| tree | ad7463374e66eb3aa61e41d96c512e67e717e349 /ext/node/lib.rs | |
| parent | d69aab62b0789dd54b8c09b54af022a38f060b5b (diff) | |
fix(ext/node): Match punycode module behavior to node (#22847)
Fixes #19214.
We were using the `idna` crate to implement our polyfill for
`punycode.toASCII` and `punycode.toUnicode`. The `idna` crate is
correct, and adheres to the IDNA2003/2008 spec, but it turns out
`node`'s implementations don't really follow any spec! Instead, node
splits the domain by `'.'` and punycode encodes/decodes each part. This
means that node's implementations will happily work on codepoints that
are disallowed by the IDNA specs, causing the error in #19214.
While fixing this, I went ahead and matched the node behavior on all of
the punycode functions and enabled node's punycode test in our
`node_compat` suite.
Diffstat (limited to 'ext/node/lib.rs')
| -rw-r--r-- | ext/node/lib.rs | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/ext/node/lib.rs b/ext/node/lib.rs index 6d5a21ace..f9553a038 100644 --- a/ext/node/lib.rs +++ b/ext/node/lib.rs @@ -261,6 +261,8 @@ deno_core::extension!(deno_node, ops::v8::op_vm_run_in_new_context, ops::idna::op_node_idna_domain_to_ascii, ops::idna::op_node_idna_domain_to_unicode, + ops::idna::op_node_idna_punycode_to_ascii, + ops::idna::op_node_idna_punycode_to_unicode, ops::idna::op_node_idna_punycode_decode, ops::idna::op_node_idna_punycode_encode, ops::zlib::op_zlib_new, |