summaryrefslogtreecommitdiff
path: root/ext/console/lib.rs
diff options
context:
space:
mode:
authorKenta Moriuchi <moriken@kimamass.com>2024-01-04 13:12:38 +0900
committerGitHub <noreply@github.com>2024-01-04 09:42:38 +0530
commitb2cd254c35b6b1b128beea0eacdb8e814d91e003 (patch)
treed55fa5910e32d8a664aff5b680e07debea93181e /ext/console/lib.rs
parent48556748577ba46db5f9212d14a0fcaa90d632f6 (diff)
fix: strict type check for cross realms (#21669)
Deno v1.39 introduces `vm.runInNewContext`. This may cause problems when using `Object.prototype.isPrototypeOf` to check built-in types. ```js import vm from "node:vm"; const err = new Error(); const crossErr = vm.runInNewContext(`new Error()`); console.assert( !(crossErr instanceof Error) ); console.assert( Object.getPrototypeOf(err) !== Object.getPrototypeOf(crossErr) ); ``` This PR changes to check using internal slots solves them. --- current: ``` > import vm from "node:vm"; undefined > vm.runInNewContext(`new Error("message")`) Error {} > vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`) Date {} ``` this PR: ``` > import vm from "node:vm"; undefined > vm.runInNewContext(`new Error("message")`) Error: message at <anonymous>:1:1 > vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`) 2018-12-10T02:26:59.002Z ``` --------- Co-authored-by: Bartek IwaƄczuk <biwanczuk@gmail.com>
Diffstat (limited to 'ext/console/lib.rs')
-rw-r--r--ext/console/lib.rs7
1 files changed, 1 insertions, 6 deletions
diff --git a/ext/console/lib.rs b/ext/console/lib.rs
index fd4d917d8..87fc8327d 100644
--- a/ext/console/lib.rs
+++ b/ext/console/lib.rs
@@ -5,7 +5,7 @@ use std::path::PathBuf;
deno_core::extension!(
deno_console,
- ops = [op_is_any_arraybuffer, op_preview_entries,],
+ ops = [op_preview_entries],
esm = ["01_console.js"],
);
@@ -13,11 +13,6 @@ pub fn get_declaration() -> PathBuf {
PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("lib.deno_console.d.ts")
}
-#[op2(fast)]
-fn op_is_any_arraybuffer(value: &v8::Value) -> bool {
- value.is_array_buffer() || value.is_shared_array_buffer()
-}
-
#[op2]
pub fn op_preview_entries<'s>(
scope: &mut v8::HandleScope<'s>,