From b2cd254c35b6b1b128beea0eacdb8e814d91e003 Mon Sep 17 00:00:00 2001 From: Kenta Moriuchi Date: Thu, 4 Jan 2024 13:12:38 +0900 Subject: fix: strict type check for cross realms (#21669) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Deno v1.39 introduces `vm.runInNewContext`. This may cause problems when using `Object.prototype.isPrototypeOf` to check built-in types. ```js import vm from "node:vm"; const err = new Error(); const crossErr = vm.runInNewContext(`new Error()`); console.assert( !(crossErr instanceof Error) ); console.assert( Object.getPrototypeOf(err) !== Object.getPrototypeOf(crossErr) ); ``` This PR changes to check using internal slots solves them. --- current: ``` > import vm from "node:vm"; undefined > vm.runInNewContext(`new Error("message")`) Error {} > vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`) Date {} ``` this PR: ``` > import vm from "node:vm"; undefined > vm.runInNewContext(`new Error("message")`) Error: message at :1:1 > vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`) 2018-12-10T02:26:59.002Z ``` --------- Co-authored-by: Bartek Iwańczuk --- ext/console/lib.rs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'ext/console/lib.rs') diff --git a/ext/console/lib.rs b/ext/console/lib.rs index fd4d917d8..87fc8327d 100644 --- a/ext/console/lib.rs +++ b/ext/console/lib.rs @@ -5,7 +5,7 @@ use std::path::PathBuf; deno_core::extension!( deno_console, - ops = [op_is_any_arraybuffer, op_preview_entries,], + ops = [op_preview_entries], esm = ["01_console.js"], ); @@ -13,11 +13,6 @@ pub fn get_declaration() -> PathBuf { PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("lib.deno_console.d.ts") } -#[op2(fast)] -fn op_is_any_arraybuffer(value: &v8::Value) -> bool { - value.is_array_buffer() || value.is_shared_array_buffer() -} - #[op2] pub fn op_preview_entries<'s>( scope: &mut v8::HandleScope<'s>, -- cgit v1.2.3