diff options
| author | Ryan Dahl <ry@tinyclouds.org> | 2018-06-18 15:55:36 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-06-18 15:55:36 +0200 |
| commit | 064d889af05365b3d2051f0db800adc1ad977f3a (patch) | |
| tree | 4e9cfb2cc9630fd32fb16dc4de4554a93cfa4b1d /deno2/deno.cc | |
| parent | e6f51fd45820222cc2efea8478ad115b310e287a (diff) | |
Fix snapshot bug. (#267)
Diffstat (limited to 'deno2/deno.cc')
| -rw-r--r-- | deno2/deno.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/deno2/deno.cc b/deno2/deno.cc index d21e0bcea..ec3665c93 100644 --- a/deno2/deno.cc +++ b/deno2/deno.cc @@ -250,8 +250,10 @@ v8::StartupData MakeSnapshot(v8::StartupData* prev_natives_blob, SerializeInternalFields, nullptr)); } + // Note that using kKeep here will cause segfaults. This is demoed in the + // "SnapshotBug" test case. auto snapshot_blob = - creator->CreateBlob(v8::SnapshotCreator::FunctionCodeHandling::kKeep); + creator->CreateBlob(v8::SnapshotCreator::FunctionCodeHandling::kClear); return snapshot_blob; } |