From 064d889af05365b3d2051f0db800adc1ad977f3a Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Mon, 18 Jun 2018 15:55:36 +0200 Subject: Fix snapshot bug. (#267) --- deno2/deno.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'deno2/deno.cc') diff --git a/deno2/deno.cc b/deno2/deno.cc index d21e0bcea..ec3665c93 100644 --- a/deno2/deno.cc +++ b/deno2/deno.cc @@ -250,8 +250,10 @@ v8::StartupData MakeSnapshot(v8::StartupData* prev_natives_blob, SerializeInternalFields, nullptr)); } + // Note that using kKeep here will cause segfaults. This is demoed in the + // "SnapshotBug" test case. auto snapshot_blob = - creator->CreateBlob(v8::SnapshotCreator::FunctionCodeHandling::kKeep); + creator->CreateBlob(v8::SnapshotCreator::FunctionCodeHandling::kClear); return snapshot_blob; } -- cgit v1.2.3