diff options
| author | Bartek Iwańczuk <biwanczuk@gmail.com> | 2023-04-14 02:41:32 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-14 02:41:32 +0200 |
| commit | cb2ca234bb39d8e02b08d2866860e8d3a00b5887 (patch) | |
| tree | 660044dbb6f6ce62c3f542ade150788870e483a5 /core/realm.rs | |
| parent | d192d84a0e0b9954882211b827f17512ad37be7d (diff) | |
refactor(core): limit number of boundary crossings between Rust and V8 (#18652)
This commit refactors "deno_core" to do fewer boundary crossings
from Rust to V8. In other words we are now calling V8 from Rust fewer
times.
This is done by merging 3 distinct callbacks into a single one. Instead
of having "op resolve" callback, "next tick" callback and "macrotask
queue" callback, we now have only "Deno.core.eventLoopTick" callback,
which is responsible for doing the same actions previous 3 callbacks.
On each of the event loop we were doing at least 2 boundary crosses
(timers macrotask queue callback and unhandled promise rejection
callback) and up to 4 crosses if there were op response and next tick
callbacks coming from Node.js compatibility layer. Now this is all done
in a single callback.
Closes https://github.com/denoland/deno/issues/18620
Diffstat (limited to 'core/realm.rs')
| -rw-r--r-- | core/realm.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/realm.rs b/core/realm.rs index e3c7a5641..1595d9160 100644 --- a/core/realm.rs +++ b/core/realm.rs @@ -15,7 +15,7 @@ use v8::Local; #[derive(Default)] pub(crate) struct ContextState { - pub(crate) js_recv_cb: Option<v8::Global<v8::Function>>, + pub(crate) js_event_loop_tick_cb: Option<v8::Global<v8::Function>>, pub(crate) js_build_custom_error_cb: Option<v8::Global<v8::Function>>, pub(crate) js_promise_reject_cb: Option<v8::Global<v8::Function>>, pub(crate) js_format_exception_cb: Option<v8::Global<v8::Function>>, |