From cb2ca234bb39d8e02b08d2866860e8d3a00b5887 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Fri, 14 Apr 2023 02:41:32 +0200 Subject: refactor(core): limit number of boundary crossings between Rust and V8 (#18652) This commit refactors "deno_core" to do fewer boundary crossings from Rust to V8. In other words we are now calling V8 from Rust fewer times. This is done by merging 3 distinct callbacks into a single one. Instead of having "op resolve" callback, "next tick" callback and "macrotask queue" callback, we now have only "Deno.core.eventLoopTick" callback, which is responsible for doing the same actions previous 3 callbacks. On each of the event loop we were doing at least 2 boundary crosses (timers macrotask queue callback and unhandled promise rejection callback) and up to 4 crosses if there were op response and next tick callbacks coming from Node.js compatibility layer. Now this is all done in a single callback. Closes https://github.com/denoland/deno/issues/18620 --- core/realm.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'core/realm.rs') diff --git a/core/realm.rs b/core/realm.rs index e3c7a5641..1595d9160 100644 --- a/core/realm.rs +++ b/core/realm.rs @@ -15,7 +15,7 @@ use v8::Local; #[derive(Default)] pub(crate) struct ContextState { - pub(crate) js_recv_cb: Option>, + pub(crate) js_event_loop_tick_cb: Option>, pub(crate) js_build_custom_error_cb: Option>, pub(crate) js_promise_reject_cb: Option>, pub(crate) js_format_exception_cb: Option>, -- cgit v1.2.3