summaryrefslogtreecommitdiff
path: root/cli
diff options
context:
space:
mode:
authorDivy Srivastava <dj.srivastava23@gmail.com>2023-01-23 00:52:18 -0800
committerGitHub <noreply@github.com>2023-01-23 14:22:18 +0530
commitb96bbc32c8a0828f997f6148111a31ec27ec08b1 (patch)
tree0dfa87d40f79cd6e70da1efc9ea21c34ca0e670a /cli
parent2e1df623804fd580d236d89d7277a28d66d7dddb (diff)
fix(napi): improve napi_is_detached_arraybuffer (#17498)
Diffstat (limited to 'cli')
-rw-r--r--cli/napi/js_native_api.rs15
1 files changed, 12 insertions, 3 deletions
diff --git a/cli/napi/js_native_api.rs b/cli/napi/js_native_api.rs
index 9f043ec94..05e07b1e5 100644
--- a/cli/napi/js_native_api.rs
+++ b/cli/napi/js_native_api.rs
@@ -2106,13 +2106,22 @@ fn napi_is_date(
#[napi_sym::napi_sym]
fn napi_is_detached_arraybuffer(
- _env: *mut Env,
+ env: *mut Env,
value: napi_value,
result: *mut bool,
) -> Result {
+ check_env!(env);
+ check_arg!(env, result);
+
let value = napi_value_unchecked(value);
- let _ab = v8::Local::<v8::ArrayBuffer>::try_from(value).unwrap();
- *result = _ab.was_detached();
+
+ *result = match v8::Local::<v8::ArrayBuffer>::try_from(value) {
+ Ok(array_buffer) => array_buffer.was_detached(),
+ Err(_) => false,
+ };
+
+ napi_clear_last_error(env);
+
Ok(())
}