From b96bbc32c8a0828f997f6148111a31ec27ec08b1 Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Mon, 23 Jan 2023 00:52:18 -0800 Subject: fix(napi): improve napi_is_detached_arraybuffer (#17498) --- cli/napi/js_native_api.rs | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) (limited to 'cli') diff --git a/cli/napi/js_native_api.rs b/cli/napi/js_native_api.rs index 9f043ec94..05e07b1e5 100644 --- a/cli/napi/js_native_api.rs +++ b/cli/napi/js_native_api.rs @@ -2106,13 +2106,22 @@ fn napi_is_date( #[napi_sym::napi_sym] fn napi_is_detached_arraybuffer( - _env: *mut Env, + env: *mut Env, value: napi_value, result: *mut bool, ) -> Result { + check_env!(env); + check_arg!(env, result); + let value = napi_value_unchecked(value); - let _ab = v8::Local::::try_from(value).unwrap(); - *result = _ab.was_detached(); + + *result = match v8::Local::::try_from(value) { + Ok(array_buffer) => array_buffer.was_detached(), + Err(_) => false, + }; + + napi_clear_last_error(env); + Ok(()) } -- cgit v1.2.3