diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2024-03-31 16:39:40 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-31 16:39:40 -0400 |
| commit | b8af46e0075f659f4e373e249b0f19b3cb0f62a9 (patch) | |
| tree | 9a029e81b6d7d4294b729dc5db860b015368b1ba /cli/tools/registry/mod.rs | |
| parent | 01445940449cedc571dcbd69caa7da58de007f2b (diff) | |
fix(check): ignore certain diagnostics in remote modules and when publishing (#23119)
Unused locals and parameters don't make sense to surface in remote
modules. Additionally, fast check can cause these kind of diagnostics
when publishing, so they should be ignored.
Closes #22959
Diffstat (limited to 'cli/tools/registry/mod.rs')
| -rw-r--r-- | cli/tools/registry/mod.rs | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/cli/tools/registry/mod.rs b/cli/tools/registry/mod.rs index b40aeaeb4..3d13a52b7 100644 --- a/cli/tools/registry/mod.rs +++ b/cli/tools/registry/mod.rs @@ -924,6 +924,10 @@ async fn build_and_check_graph_for_publish( }, ) .await?; + // ignore unused parameter diagnostics that may occur due to fast check + // not having function body implementations + let check_diagnostics = + check_diagnostics.filter(|d| d.include_when_remote()); if !check_diagnostics.is_empty() { bail!( concat!( |