From b8af46e0075f659f4e373e249b0f19b3cb0f62a9 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Sun, 31 Mar 2024 16:39:40 -0400 Subject: fix(check): ignore certain diagnostics in remote modules and when publishing (#23119) Unused locals and parameters don't make sense to surface in remote modules. Additionally, fast check can cause these kind of diagnostics when publishing, so they should be ignored. Closes #22959 --- cli/tools/registry/mod.rs | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'cli/tools/registry/mod.rs') diff --git a/cli/tools/registry/mod.rs b/cli/tools/registry/mod.rs index b40aeaeb4..3d13a52b7 100644 --- a/cli/tools/registry/mod.rs +++ b/cli/tools/registry/mod.rs @@ -924,6 +924,10 @@ async fn build_and_check_graph_for_publish( }, ) .await?; + // ignore unused parameter diagnostics that may occur due to fast check + // not having function body implementations + let check_diagnostics = + check_diagnostics.filter(|d| d.include_when_remote()); if !check_diagnostics.is_empty() { bail!( concat!( -- cgit v1.2.3