diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2023-05-22 16:55:04 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-22 16:55:04 -0400 |
| commit | 7b4c483aa159794cdb9d57d3252c2980fba45469 (patch) | |
| tree | b1c3b0ab080e98ab20f470fbad5b1aba05045dfb /cli/npm/resolvers/mod.rs | |
| parent | 612226de8e2fe3068d981866242bacedfceb9734 (diff) | |
fix(npm): store npm binary command resolution in lockfile (#19219)
Part of #19038
Closes #19034 (eliminates the time spent re-resolving)
Diffstat (limited to 'cli/npm/resolvers/mod.rs')
| -rw-r--r-- | cli/npm/resolvers/mod.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/cli/npm/resolvers/mod.rs b/cli/npm/resolvers/mod.rs index 0f123c382..168786407 100644 --- a/cli/npm/resolvers/mod.rs +++ b/cli/npm/resolvers/mod.rs @@ -159,7 +159,7 @@ impl CliNpmResolver { /// Adds package requirements to the resolver and ensures everything is setup. pub async fn add_package_reqs( &self, - packages: Vec<NpmPackageReq>, + packages: &[NpmPackageReq], ) -> Result<(), AnyError> { if packages.is_empty() { return Ok(()); @@ -182,7 +182,7 @@ impl CliNpmResolver { /// This will retrieve and resolve package information, but not cache any package files. pub async fn set_package_reqs( &self, - packages: Vec<NpmPackageReq>, + packages: &[NpmPackageReq], ) -> Result<(), AnyError> { self.resolution.set_package_reqs(packages).await } @@ -212,7 +212,7 @@ impl CliNpmResolver { ) -> Result<(), AnyError> { // add and ensure this isn't added to the lockfile let package_reqs = vec![NpmPackageReq::from_str("@types/node").unwrap()]; - self.resolution.add_package_reqs(package_reqs).await?; + self.resolution.add_package_reqs(&package_reqs).await?; self.fs_resolver.cache_packages().await?; Ok(()) |