From 7b4c483aa159794cdb9d57d3252c2980fba45469 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Mon, 22 May 2023 16:55:04 -0400 Subject: fix(npm): store npm binary command resolution in lockfile (#19219) Part of #19038 Closes #19034 (eliminates the time spent re-resolving) --- cli/npm/resolvers/mod.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'cli/npm/resolvers/mod.rs') diff --git a/cli/npm/resolvers/mod.rs b/cli/npm/resolvers/mod.rs index 0f123c382..168786407 100644 --- a/cli/npm/resolvers/mod.rs +++ b/cli/npm/resolvers/mod.rs @@ -159,7 +159,7 @@ impl CliNpmResolver { /// Adds package requirements to the resolver and ensures everything is setup. pub async fn add_package_reqs( &self, - packages: Vec, + packages: &[NpmPackageReq], ) -> Result<(), AnyError> { if packages.is_empty() { return Ok(()); @@ -182,7 +182,7 @@ impl CliNpmResolver { /// This will retrieve and resolve package information, but not cache any package files. pub async fn set_package_reqs( &self, - packages: Vec, + packages: &[NpmPackageReq], ) -> Result<(), AnyError> { self.resolution.set_package_reqs(packages).await } @@ -212,7 +212,7 @@ impl CliNpmResolver { ) -> Result<(), AnyError> { // add and ensure this isn't added to the lockfile let package_reqs = vec![NpmPackageReq::from_str("@types/node").unwrap()]; - self.resolution.add_package_reqs(package_reqs).await?; + self.resolution.add_package_reqs(&package_reqs).await?; self.fs_resolver.cache_packages().await?; Ok(()) -- cgit v1.2.3