diff options
| author | Ryan Dahl <ry@tinyclouds.org> | 2018-12-23 17:08:08 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-12-23 17:08:08 -0500 |
| commit | 9909e8a7590c8b68e6ae3b3752cecd86f8841cad (patch) | |
| tree | cff8672004e8f5ed8e35ecb79fabdda057f75b10 | |
| parent | f8473bf22f3d3972bf5f725b5e4a1849a3d8f726 (diff) | |
Upgrade V8 to 7.2.502.16 (#1403)
| -rw-r--r-- | gclient_config.py | 2 | ||||
| -rw-r--r-- | libdeno/BUILD.gn | 2 | ||||
| -rw-r--r-- | libdeno/api.cc | 3 | ||||
| m--------- | third_party | 0 |
4 files changed, 4 insertions, 3 deletions
diff --git a/gclient_config.py b/gclient_config.py index 75f6d41e6..d108986d3 100644 --- a/gclient_config.py +++ b/gclient_config.py @@ -1,6 +1,6 @@ # Copyright 2018 the Deno authors. All rights reserved. MIT license. solutions = [{ - 'url': 'https://chromium.googlesource.com/v8/v8.git@7.1.302.4', + 'url': 'https://chromium.googlesource.com/v8/v8.git@7.2.502.16', 'name': 'v8', 'deps_file': 'DEPS', 'custom_deps': { diff --git a/libdeno/BUILD.gn b/libdeno/BUILD.gn index f2a9228c5..bf780cbaa 100644 --- a/libdeno/BUILD.gn +++ b/libdeno/BUILD.gn @@ -1,6 +1,6 @@ # Copyright 2018 the Deno authors. All rights reserved. MIT license. -import("./deno.gni") import("//third_party/v8/gni/v8.gni") +import("./deno.gni") config("deno_config") { include_dirs = [ "//third_party/v8" ] # This allows us to v8/src/base/ libraries. diff --git a/libdeno/api.cc b/libdeno/api.cc index 472181819..e6bc670c7 100644 --- a/libdeno/api.cc +++ b/libdeno/api.cc @@ -154,9 +154,10 @@ int deno_respond(Deno* d_, void* user_data, int32_t req_id, deno_buf buf) { v8::Local<v8::Value> args[1]; args[0] = deno::ImportBuf(d, buf); - recv_->Call(context->Global(), 1, args); + auto v = recv_->Call(context, context->Global(), 1, args); if (try_catch.HasCaught()) { + CHECK(v.IsEmpty()); deno::HandleException(context, try_catch.Exception()); return 1; } diff --git a/third_party b/third_party -Subproject f5583353dcef518fc4881e6b2329e8b601ccd04 +Subproject 20d8e1d12d1dea843a238576ff988522c028daa |