From 9909e8a7590c8b68e6ae3b3752cecd86f8841cad Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Sun, 23 Dec 2018 17:08:08 -0500 Subject: Upgrade V8 to 7.2.502.16 (#1403) --- gclient_config.py | 2 +- libdeno/BUILD.gn | 2 +- libdeno/api.cc | 3 ++- third_party | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/gclient_config.py b/gclient_config.py index 75f6d41e6..d108986d3 100644 --- a/gclient_config.py +++ b/gclient_config.py @@ -1,6 +1,6 @@ # Copyright 2018 the Deno authors. All rights reserved. MIT license. solutions = [{ - 'url': 'https://chromium.googlesource.com/v8/v8.git@7.1.302.4', + 'url': 'https://chromium.googlesource.com/v8/v8.git@7.2.502.16', 'name': 'v8', 'deps_file': 'DEPS', 'custom_deps': { diff --git a/libdeno/BUILD.gn b/libdeno/BUILD.gn index f2a9228c5..bf780cbaa 100644 --- a/libdeno/BUILD.gn +++ b/libdeno/BUILD.gn @@ -1,6 +1,6 @@ # Copyright 2018 the Deno authors. All rights reserved. MIT license. -import("./deno.gni") import("//third_party/v8/gni/v8.gni") +import("./deno.gni") config("deno_config") { include_dirs = [ "//third_party/v8" ] # This allows us to v8/src/base/ libraries. diff --git a/libdeno/api.cc b/libdeno/api.cc index 472181819..e6bc670c7 100644 --- a/libdeno/api.cc +++ b/libdeno/api.cc @@ -154,9 +154,10 @@ int deno_respond(Deno* d_, void* user_data, int32_t req_id, deno_buf buf) { v8::Local args[1]; args[0] = deno::ImportBuf(d, buf); - recv_->Call(context->Global(), 1, args); + auto v = recv_->Call(context, context->Global(), 1, args); if (try_catch.HasCaught()) { + CHECK(v.IsEmpty()); deno::HandleException(context, try_catch.Exception()); return 1; } diff --git a/third_party b/third_party index f5583353d..20d8e1d12 160000 --- a/third_party +++ b/third_party @@ -1 +1 @@ -Subproject commit f5583353dcef518fc4881e6b2329e8b601ccd042 +Subproject commit 20d8e1d12d1dea843a238576ff988522c028daa0 -- cgit v1.2.3