diff options
| author | Andreu Botella <abb@randomunok.com> | 2021-12-30 02:05:26 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-30 02:05:26 +0100 |
| commit | 0ead12d673ecc8c19bdf77043550b80b8eb81475 (patch) | |
| tree | b015dd80d596766c8e3e1e9f338ac6de10e49cd4 | |
| parent | 167982be9e7af35e6c12ef6c40c002200bf5e0c0 (diff) | |
fix(doc): Make private types which show up in the rustdocs public (#13230)
`CrossIsolateStore`, `ExtensionBuilder` and `InMemoryChannelResource`
are private types which are referred to by other public APIs, and so
don't show up as links in the rustdoc. This is especially confusing for
`ExtensionBuilder`, since there is nothing in the docs that explains how
to build an extension.
Exposing these three types doesn't add any new capabilities:
`ExtensionBuilder` can be created from `Extension::builder()`,
`SharedArrayBufferStore` and `CompiledWasmModuleStore` already enable
doing anything that `CrossIsolateStore` can do by itself, and
`InMemoryChannelResource` isn't constructable.
| -rw-r--r-- | core/lib.rs | 2 | ||||
| -rw-r--r-- | ext/broadcast_channel/lib.rs | 1 |
2 files changed, 3 insertions, 0 deletions
diff --git a/core/lib.rs b/core/lib.rs index 606304ad5..acaa273e2 100644 --- a/core/lib.rs +++ b/core/lib.rs @@ -88,6 +88,7 @@ pub use crate::resources::Resource; pub use crate::resources::ResourceId; pub use crate::resources::ResourceTable; pub use crate::runtime::CompiledWasmModuleStore; +pub use crate::runtime::CrossIsolateStore; pub use crate::runtime::GetErrorClassFn; pub use crate::runtime::JsErrorCreateFn; pub use crate::runtime::JsRuntime; @@ -96,6 +97,7 @@ pub use crate::runtime::SharedArrayBufferStore; pub use crate::runtime::Snapshot; // pub use crate::runtime_modules::include_js_files!; pub use crate::extensions::Extension; +pub use crate::extensions::ExtensionBuilder; pub use crate::extensions::OpMiddlewareFn; pub use crate::extensions::OpPair; diff --git a/ext/broadcast_channel/lib.rs b/ext/broadcast_channel/lib.rs index b499d6fbf..ad6417558 100644 --- a/ext/broadcast_channel/lib.rs +++ b/ext/broadcast_channel/lib.rs @@ -3,6 +3,7 @@ mod in_memory_broadcast_channel; pub use in_memory_broadcast_channel::InMemoryBroadcastChannel; +pub use in_memory_broadcast_channel::InMemoryBroadcastChannelResource; use async_trait::async_trait; use deno_core::error::AnyError; |