From 0ead12d673ecc8c19bdf77043550b80b8eb81475 Mon Sep 17 00:00:00 2001 From: Andreu Botella Date: Thu, 30 Dec 2021 02:05:26 +0100 Subject: fix(doc): Make private types which show up in the rustdocs public (#13230) `CrossIsolateStore`, `ExtensionBuilder` and `InMemoryChannelResource` are private types which are referred to by other public APIs, and so don't show up as links in the rustdoc. This is especially confusing for `ExtensionBuilder`, since there is nothing in the docs that explains how to build an extension. Exposing these three types doesn't add any new capabilities: `ExtensionBuilder` can be created from `Extension::builder()`, `SharedArrayBufferStore` and `CompiledWasmModuleStore` already enable doing anything that `CrossIsolateStore` can do by itself, and `InMemoryChannelResource` isn't constructable. --- core/lib.rs | 2 ++ ext/broadcast_channel/lib.rs | 1 + 2 files changed, 3 insertions(+) diff --git a/core/lib.rs b/core/lib.rs index 606304ad5..acaa273e2 100644 --- a/core/lib.rs +++ b/core/lib.rs @@ -88,6 +88,7 @@ pub use crate::resources::Resource; pub use crate::resources::ResourceId; pub use crate::resources::ResourceTable; pub use crate::runtime::CompiledWasmModuleStore; +pub use crate::runtime::CrossIsolateStore; pub use crate::runtime::GetErrorClassFn; pub use crate::runtime::JsErrorCreateFn; pub use crate::runtime::JsRuntime; @@ -96,6 +97,7 @@ pub use crate::runtime::SharedArrayBufferStore; pub use crate::runtime::Snapshot; // pub use crate::runtime_modules::include_js_files!; pub use crate::extensions::Extension; +pub use crate::extensions::ExtensionBuilder; pub use crate::extensions::OpMiddlewareFn; pub use crate::extensions::OpPair; diff --git a/ext/broadcast_channel/lib.rs b/ext/broadcast_channel/lib.rs index b499d6fbf..ad6417558 100644 --- a/ext/broadcast_channel/lib.rs +++ b/ext/broadcast_channel/lib.rs @@ -3,6 +3,7 @@ mod in_memory_broadcast_channel; pub use in_memory_broadcast_channel::InMemoryBroadcastChannel; +pub use in_memory_broadcast_channel::InMemoryBroadcastChannelResource; use async_trait::async_trait; use deno_core::error::AnyError; -- cgit v1.2.3