diff options
| author | Mathias Lafeldt <mathias.lafeldt@gmail.com> | 2022-08-19 14:17:18 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-19 08:17:18 -0400 |
| commit | 1848c7e361f1a3a33487b60ab6fcb61ed1f62273 (patch) | |
| tree | 224d68a9ed594badcf4785b77941405e9b8eba6a /.github/workflows | |
| parent | 25a109d9ea27ad3a76fdce14bba283e953af9bce (diff) | |
Fix: Honor linter rules in CI and locally (#15492)
RUSTFLAGS take precedence over `target.<triple>.rustflags`. Therefore,
setting the env var globally in CI would always override whatever linter
rules are allowed or denied in .cargo/config.toml.
With this change, we ensure that problems are detected both in CI and
locally, using either cargo clippy or lint.js.
Diffstat (limited to '.github/workflows')
| -rw-r--r-- | .github/workflows/ci.yml | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 36656d7c6..2da07b31f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -140,9 +140,6 @@ jobs: service_account_key: ${{ secrets.GCP_SA_KEY }} export_default_credentials: true - - name: Error on warning - run: echo "RUSTFLAGS=-D warnings" >> $GITHUB_ENV - - name: Configure canary build if: | matrix.job == 'test' && |