From 1848c7e361f1a3a33487b60ab6fcb61ed1f62273 Mon Sep 17 00:00:00 2001
From: Mathias Lafeldt <mathias.lafeldt@gmail.com>
Date: Fri, 19 Aug 2022 14:17:18 +0200
Subject: Fix: Honor linter rules in CI and locally (#15492)

RUSTFLAGS take precedence over `target.<triple>.rustflags`. Therefore,
setting the env var globally in CI would always override whatever linter
rules are allowed or denied in .cargo/config.toml.

With this change, we ensure that problems are detected both in CI and
locally, using either cargo clippy or lint.js.
---
 .github/workflows/ci.yml | 3 ---
 1 file changed, 3 deletions(-)

(limited to '.github/workflows')

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 36656d7c6..2da07b31f 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -140,9 +140,6 @@ jobs:
           service_account_key: ${{ secrets.GCP_SA_KEY }}
           export_default_credentials: true
 
-      - name: Error on warning
-        run: echo "RUSTFLAGS=-D warnings" >> $GITHUB_ENV
-
       - name: Configure canary build
         if: |
           matrix.job == 'test' &&
-- 
cgit v1.2.3