summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--CMakeLists.txt39
-rw-r--r--src/main.c720
-rw-r--r--src/mscp.c82
-rw-r--r--src/mscp.h25
-rw-r--r--src/path.c29
-rw-r--r--src/path.h19
-rw-r--r--src/util.h5
7 files changed, 283 insertions, 636 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt
index df3a542..0f2988e 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -19,9 +19,6 @@ if(APPLE)
endif() # APPLE
-# mscp executable
-add_executable(mscp src/main.c src/platform.c src/ssh.c src/file.c src/pprint.c)
-
set(MSCP_LINK_LIBS m pthread)
set(MSCP_LINK_DIRS "")
set(MSCP_COMPILE_OPTS "")
@@ -40,17 +37,12 @@ list(APPEND MSCP_LINK_LIBS ${OPENSSL_LIBRARIES})
find_package(ZLIB)
list(APPEND MSCP_LINK_LIBS ${ZLIB_LIBRARIES})
-target_include_directories(mscp PRIVATE ${MSCP_INCLUDE_DIRS})
-target_link_directories(mscp PRIVATE ${MSCP_LINK_DIRS})
-target_link_libraries(mscp PRIVATE ${MSCP_LINK_LIBS})
-target_compile_options(mscp PRIVATE ${MSCP_COMPILE_OPTS})
-target_compile_definitions(mscp PUBLIC _VERSION="${PROJECT_VERSION}")
-install(TARGETS mscp RUNTIME DESTINATION bin)
+set(LIBMSCP_SRC src/mscp.c src/ssh.c src/path.c src/pprint.c src/platform.c)
-# libmscp
-add_library(mscp-shared SHARED src/mscp.c src/ssh.c src/path.c src/pprint.c src/platform.c )
+# shared libmscp
+add_library(mscp-shared SHARED ${LIBMSCP_SRC})
target_include_directories(mscp-shared PRIVATE ${MSCP_INCLUDE_DIRS})
target_link_directories(mscp-shared PRIVATE ${MSCP_LINK_DIRS})
target_link_libraries(mscp-shared PRIVATE ${MSCP_LINK_LIBS})
@@ -59,12 +51,25 @@ set_target_properties(mscp-shared
PROPERTIES
OUTPUT_NAME mscp)
-# test executable
-add_executable(test-mscp src/test.c src/ssh.c src/path.c src/pprint.c src/platform.c)
-target_include_directories(test-mscp PRIVATE ${MSCP_INCLUDE_DIRS})
-target_link_directories(test-mscp PRIVATE ${MSCP_LINK_DIRS})
-target_link_libraries(test-mscp PRIVATE ${MSCP_LINK_LIBS})
-target_compile_options(test-mscp PRIVATE ${MSCP_COMPILE_OPTS})
+# static libmscp
+add_library(mscp-static STATIC ${LIBMSCP_SRC})
+target_include_directories(mscp-static PRIVATE ${MSCP_INCLUDE_DIRS})
+target_link_directories(mscp-static PRIVATE ${MSCP_LINK_DIRS})
+target_link_libraries(mscp-static PRIVATE ${MSCP_LINK_LIBS})
+target_compile_options(mscp-static PRIVATE ${MSCP_COMPILE_OPTS})
+set_target_properties(mscp-static
+ PROPERTIES
+ OUTPUT_NAME mscp)
+
+# mscp executable
+add_executable(mscp src/main.c)
+target_include_directories(mscp PRIVATE ${MSCP_INCLUDE_DIRS})
+target_compile_definitions(mscp PUBLIC _VERSION="${PROJECT_VERSION}")
+target_link_libraries(mscp mscp-static)
+
+
+install(TARGETS mscp RUNTIME DESTINATION bin)
+
# Test
add_test(NAME pytest
diff --git a/src/main.c b/src/main.c
index 48eb2eb..257f61e 100644
--- a/src/main.c
+++ b/src/main.c
@@ -1,20 +1,11 @@
#include <stdio.h>
#include <stdlib.h>
-#include <stdbool.h>
#include <unistd.h>
-#include <signal.h>
-#include <sys/time.h>
-#include <sys/ioctl.h>
-#include <math.h>
-#include <pthread.h>
+#include <limits.h>
-#include <list.h>
+#include <mscp.h>
#include <util.h>
-#include <ssh.h>
-#include <file.h>
-#include <pprint.h>
-#include <atomic.h>
-#include <platform.h>
+
#ifndef _VERSION /* passed through cmake */
#define VERSION "(unknown)"
@@ -22,61 +13,6 @@
#define VERSION _VERSION
#endif
-#define DEFAULT_MIN_CHUNK_SZ (64 << 20) /* 64MB */
-#define DEFAULT_NR_AHEAD 32
-#define DEFAULT_BUF_SZ 16384
-/* XXX: we use 16384 byte buffer pointed by
- * https://api.libssh.org/stable/libssh_tutor_sftp.html. The larget
- * read length from sftp_async_read is 65536 byte. Read sizes larger
- * than 65536 cause a situation where data remainds but
- * sftp_async_read returns 0.
- */
-
-
-
-struct mscp_thread {
- sftp_session sftp;
-
- pthread_t tid;
- int cpu;
- size_t done; /* copied bytes */
- bool finished;
- int ret;
-};
-
-struct mscp {
- char *host; /* remote host (and username) */
- struct ssh_opts *opts; /* ssh parameters */
-
- struct list_head file_list;
- struct list_head chunk_list; /* stack of chunks */
- lock chunk_lock; /* lock for chunk list */
-
- char *target;
-
- int nr_threads; /* number of threads */
- int buf_sz; /* i/o buf size */
- int nr_ahead; /* # of ahead read command for remote to local copy */
-
- struct mscp_thread *threads;
-} m;
-
-void *mscp_copy_thread(void *arg);
-int mscp_stat_init();
-void mscp_stat_final();
-
-
-
-void stop_copy_threads(int sig)
-{
- int n;
-
- pr("stopping...\n");
- for (n = 0; n < m.nr_threads; n++) {
- if (m.threads[n].tid && !m.threads[n].finished)
- pthread_cancel(m.threads[n].tid);
- }
-}
void usage(bool print_help) {
printf("mscp v" VERSION ": copy files over multiple ssh connections\n"
@@ -117,232 +53,205 @@ void usage(bool print_help) {
"\n");
}
-char *find_hostname(int ind, int argc, char **argv)
+char *split_remote_and_path(const char *string, char **remote, char **path)
{
- char *h, *hostnames[argc];
- int n, cnt = 0;
+ char *s, *p;
- for (n = ind; n < argc; n++) {
- h = file_find_hostname(argv[n]);
- if (h)
- hostnames[cnt++] = h;
- }
+ /* split user@host:path into user@host, and path.
+ * return value is strdup()ed memory (for free()).
+ */
- if (cnt == 0)
+ if (!(s = strdup(string))) {
+ pr_err("failed to allocate memory: %s\n", strerrno());
return NULL;
-
- /* check all hostnames are identical */
- for (n = 1; n < cnt; n++) {
- int s1 = strlen(hostnames[n - 1]);
- int s2 = strlen(hostnames[n]);
- if (s1 != s2) {
- pr_err("different hostnames: %s and %s\n",
- hostnames[n - 1], hostnames[n]);
- goto err_out;
- }
- if (strncmp(hostnames[n - 1], hostnames[n], s1) != 0) {
- pr_err("different hostnames: %s and %s\n",
- hostnames[n - 1], hostnames[n]);
- goto err_out;
- }
}
- for (n = 1; n < cnt; n++) {
- free(hostnames[n]);
+ if ((p = strchr(s, ':'))) {
+ if (p == s || ((p > s) && *(p - 1) == '\\')) {
+ /* first byte is colon, or escaped colon. no user@host here */
+ goto no_remote;
+ } else {
+ /* we found ':', so this is remote:path notation. split it */
+ *p = '\0';
+ *remote = s;
+ *path = p + 1;
+ return s;
+ }
}
- return hostnames[0];
-
-err_out:
- for (n = 0; n < cnt; n++) {
- free(hostnames[n]);
- }
- return NULL;
+no_remote:
+ *remote = NULL;
+ *path = s;
+ return s;
}
-int expand_coremask(const char *coremask, int **cores, int *nr_cores)
+struct target {
+ char *remote;
+ char *path;
+};
+
+struct target *validate_targets(char **arg, int len)
{
- int n, *core_list, core_list_len = 0, nr_usable, nr_all;
- char c[2] = { 'x', '\0' };
- const char *_coremask;
- long v, needle;
- int ncores = nr_cpus();
-
- /*
- * This function returns array of usable cores in `cores` and
- * returns the number of usable cores (array length) through
- * nr_cores.
+ /* arg is array of source ... remote.
+ * There are two cases:
+ *
+ * 1. remote:path remote:path ... path, remote to local copy
+ * 2. path path ... remote:path, local to remote copy.
+ *
+ * This function split (remote:)path args into struct target,
+ * and validate all remotes are identical (mscp does not support
+ * remote to remote copy).
*/
- if (strncmp(coremask, "0x", 2) == 0)
- _coremask = coremask + 2;
- else
- _coremask = coremask;
+ struct target *t;
+ char *r;
+ int n;
- core_list = realloc(NULL, sizeof(int) * 64);
- if (!core_list) {
- pr_err("failed to realloc: %s\n", strerrno());
- return -1;
+ if ((t = calloc(len, sizeof(struct target))) == NULL) {
+ pr_err("failed to allocate memory: %s\n", strerrno());
+ return NULL;
}
+ memset(t, 0, len * sizeof(struct target));
- nr_usable = 0;
- nr_all = 0;
- for (n = strlen(_coremask) - 1; n >=0; n--) {
- c[0] = _coremask[n];
- v = strtol(c, NULL, 16);
- if (v == LONG_MIN || v == LONG_MAX) {
- pr_err("invalid coremask: %s\n", coremask);
- return -1;
- }
+ /* split remote:path into remote and path */
+ for (n = 0; n < len; n++) {
+ if (split_remote_and_path(arg[n], &t[n].remote, &t[n].path) == NULL)
+ goto free_target_out;
+ }
- for (needle = 0x01; needle < 0x10; needle <<= 1) {
- nr_all++;
- if (nr_all > ncores)
- break; /* too long coremask */
- if (v & needle) {
- nr_usable++;
- core_list = realloc(core_list, sizeof(int) * nr_usable);
- if (!core_list) {
- pr_err("failed to realloc: %s\n", strerrno());
- return -1;
- }
- core_list[nr_usable - 1] = nr_all - 1;
- }
+ /* check all remote are identical. t[len - 1] is destination,
+ * so we need to check t[0] to t[len - 2] having the identical
+ * remote */
+ r = t[0].remote;
+ for (n = 1; n < len - 1; n++) {
+ if (!r && t[n].remote) {
+ goto invalid_remotes;
+ }
+ if (r) {
+ if (!t[n].remote ||
+ strlen(r) != strlen(t[n].remote) ||
+ strcmp(r, t[n].remote) != 0)
+ goto invalid_remotes;
}
}
- if (nr_usable < 1) {
- pr_err("invalid core mask: %s\n", coremask);
- return -1;
+ /* check inconsistent remote position in args */
+ if (t[0].remote == NULL && t[len - 1].remote == NULL) {
+ pr_err("no remote host given\n");
+ goto free_split_out;
}
- *cores = core_list;
- *nr_cores = nr_usable;
- return 0;
-}
+ if (t[0].remote != NULL && t[len - 1].remote != NULL) {
+ pr_err("no local path given\n");
+ goto free_split_out;
+ }
-int default_nr_threads()
-{
- return (int)(floor(log(nr_cpus()) * 2) + 1);
+ return t;
+
+invalid_remotes:
+ pr_err("specified remote host invalid\n");
+
+free_split_out:
+ for (n = 0; n < len; n++)
+ t[n].remote ? free(t[n].remote) : free(t[n].path);
+
+free_target_out:
+ free(t);
+ return NULL;
}
int main(int argc, char **argv)
{
- struct ssh_opts opts;
- sftp_session ctrl;
- int min_chunk_sz = DEFAULT_MIN_CHUNK_SZ;
- int max_chunk_sz = 0;
- char *coremask = NULL;;
- int verbose = 1;
- bool dryrun = false;
- int ret = 0, n;
- int *cores, nr_cores;
- char ch;
-
- memset(&opts, 0, sizeof(opts));
- opts.nodelay = 1;
- memset(&m, 0, sizeof(m));
- INIT_LIST_HEAD(&m.file_list);
- INIT_LIST_HEAD(&m.chunk_list);
- lock_init(&m.chunk_lock);
- m.nr_ahead = DEFAULT_NR_AHEAD;
- m.buf_sz = DEFAULT_BUF_SZ;
- m.nr_threads = default_nr_threads();
+ struct mscp_opts o;
+ struct mscp *m;
+ struct target *t;
+ int ch, n, i;
+ char *remote;
+
+ memset(&o, 0, sizeof(o));
while ((ch = getopt(argc, argv, "n:m:s:S:a:b:vqDrl:p:i:c:M:CHdNh")) != -1) {
switch (ch) {
case 'n':
- m.nr_threads = atoi(optarg);
- if (m.nr_threads < 1) {
+ o.nr_threads = atoi(optarg);
+ if (o.nr_threads < 1) {
pr_err("invalid number of connections: %s\n", optarg);
return 1;
}
break;
case 'm':
- coremask = optarg;
+ strncpy(o.coremask, optarg, sizeof(o.coremask));
break;
case 's':
- min_chunk_sz = atoi(optarg);
- if (min_chunk_sz < getpagesize()) {
- pr_err("min chunk size must be "
- "larger than or equal to %d: %s\n",
- getpagesize(), optarg);
- return 1;
- }
- if (min_chunk_sz % getpagesize() != 0) {
- pr_err("min chunk size must be "
- "multiple of page size %d: %s\n",
- getpagesize(), optarg);
- return -1;
- }
+ o.min_chunk_sz = atoi(optarg);
break;
case 'S':
- max_chunk_sz = atoi(optarg);
- if (max_chunk_sz < getpagesize()) {
- pr_err("max chunk size must be "
- "larger than or equal to %d: %s\n",
- getpagesize(), optarg);
- return 1;
- }
- if (max_chunk_sz % getpagesize() != 0) {
- pr_err("max chunk size must be "
- "multiple of page size %d: %s\n",
- getpagesize(), optarg);
- return -1;
- }
+ o.max_chunk_sz = atoi(optarg);
break;
case 'a':
- m.nr_ahead = atoi(optarg);
- if (m.nr_ahead < 1) {
- pr_err("invalid number of ahead: %s\n", optarg);
- return -1;
- }
+ o.nr_ahead = atoi(optarg);
break;
case 'b':
- m.buf_sz = atoi(optarg);
- if (m.buf_sz < 1) {
- pr_err("invalid buffer size: %s\n", optarg);
- return -1;
- }
+ o.buf_sz = atoi(optarg);
break;
case 'v':
- verbose++;
+ o.verbose_level++;
break;
case 'q':
- verbose = -1;
+ o.verbose_level = -1;
break;
case 'D':
- dryrun = true;
+ o.dryrun = true;
break;
case 'r':
/* for compatibility with scp */
break;
case 'l':
- opts.login_name = optarg;
+ if (strlen(optarg) > MSCP_MAX_LOGIN_NAME - 1) {
+ pr_err("too long login name: %s\n", optarg);
+ return -1;
+ }
+ strncpy(o.ssh_login_name, optarg, MSCP_MAX_LOGIN_NAME - 1);
break;
case 'p':
- opts.port = optarg;
+ if (strlen(optarg) > MSCP_MAX_PORT_STR - 1) {
+ pr_err("too long port string: %s\n", optarg);
+ return -1;
+ }
+ strncpy(o.ssh_port, optarg, MSCP_MAX_PORT_STR);
break;
case 'i':
- opts.identity = optarg;
+ if (strlen(optarg) > MSCP_MAX_IDENTITY_PATH - 1) {
+ pr_err("too long identity path: %s\n", optarg);
+ return -1;
+ }
+ strncpy(o.ssh_identity, optarg, MSCP_MAX_IDENTITY_PATH);
break;
case 'c':
- opts.cipher = optarg;
+ if (strlen(optarg) > MSCP_MAX_CIPHER_STR - 1) {
+ pr_err("too long cipher string: %s\n", optarg);
+ return -1;
+ }
+ strncpy(o.ssh_cipher_spec, optarg, MSCP_MAX_CIPHER_STR);
break;
case 'M':
- opts.hmac = optarg;
+ if (strlen(optarg) > MSCP_MAX_HMACP_STR - 1) {
+ pr_err("too long hmac string: %s\n", optarg);
+ return -1;
+ }
+ strncpy(o.ssh_hmac_spec, optarg, MSCP_MAX_HMACP_STR);
break;
case 'C':
- opts.compress++;
+ o.ssh_compress_level++;
break;
case 'H':
- opts.no_hostkey_check = true;
+ o.ssh_no_hostkey_check = true;
break;
case 'd':
- opts.debuglevel++;
+ o.ssh_debug_level++;
break;
case 'N':
- opts.nodelay = 0;
+ o.ssh_disable_tcp_nodely = true;
break;
case 'h':
usage(true);
@@ -353,365 +262,48 @@ int main(int argc, char **argv)
}
}
- pprint_set_level(verbose);
-
if (argc - optind < 2) {
/* mscp needs at lease 2 (src and target) argument */
usage(false);
return 1;
}
- m.target = argv[argc - 1];
-
- if (max_chunk_sz > 0 && min_chunk_sz > max_chunk_sz) {
- pr_err("smaller max chunk size than min chunk size: %d < %d\n",
- max_chunk_sz, min_chunk_sz);
- return 1;
- }
-
- /* expand usable cores from coremask */
- if (coremask) {
- if (expand_coremask(coremask, &cores, &nr_cores) < 0)
- return -1;
- pprint(2, "cpu cores:");
- for (n = 0; n < nr_cores; n++)
- pprint(2, " %d", cores[n]);
- pprint(2, "\n");
- }
- pprint2("number of connections: %d\n", m.nr_threads);
-
- /* create control session */
- m.host = find_hostname(optind, argc, argv);
- if (!m.host) {
- pr_err("no remote host given\n");
- return 1;
- }
- pprint3("connecting to %s for checking destinations...\n", m.host);
- ctrl = ssh_init_sftp_session(m.host, &opts);
- if (!ctrl)
- return 1;
- m.opts = &opts; /* save ssh-able ssh_opts */
-
-
- /* fill file list */
- ret = file_fill(ctrl, &m.file_list, &argv[optind], argc - optind - 1, m.target);
- if (ret < 0)
- goto out;
-
-#ifdef DEBUG
- file_dump(&m.file_list);
-#endif
-
- /* fill chunk list */
- ret = chunk_fill(&m.file_list, &m.chunk_list,
- m.nr_threads, min_chunk_sz, max_chunk_sz);
- if (ret < 0)
- goto out;
-
-#ifdef DEBUG
- chunk_dump(&m.chunk_list);
-#endif
-
- if (dryrun) {
- ssh_sftp_close(ctrl);
- return 0;
- }
-
- /* prepare thread instances */
- if ((n = list_count(&m.chunk_list)) < m.nr_threads) {
- pprint2("we have only %d chunk(s). "
- "set number of connections to %d\n", n, n);
- m.nr_threads = n;
- }
+ i = argc - optind;
- m.threads = calloc(m.nr_threads, sizeof(struct mscp_thread));
- memset(m.threads, 0, m.nr_threads * sizeof(struct mscp_thread));
- for (n = 0; n < m.nr_threads; n++) {
- struct mscp_thread *t = &m.threads[n];
- t->finished = false;
- if (!coremask)
- t->cpu = -1;
- else
- t->cpu = cores[n % nr_cores];
-
- if (n == 0) {
- t->sftp = ctrl; /* reuse ctrl sftp session */
- ctrl = NULL;
- } else {
- pprint3("connecting to %s for a copy thread...\n", m.host);
- t->sftp = ssh_init_sftp_session(m.host, m.opts);
- }
- if (!t->sftp) {
- ret = 1;
- goto out;
- }
- }
-
- /* init mscp stat for printing progress bar */
- if (mscp_stat_init() < 0) {
- ret = 1;
- goto out;
- }
-
- /* spawn copy threads */
- for (n = 0; n < m.nr_threads; n++) {
- struct mscp_thread *t = &m.threads[n];
- ret = pthread_create(&t->tid, NULL, mscp_copy_thread, t);
- if (ret < 0) {
- pr_err("pthread_create error: %d\n", ret);
- stop_copy_threads(0);
- ret = 1;
- goto join_out;
- }
- }
-
- /* register SIGINT to stop threads */
- if (signal(SIGINT, stop_copy_threads) == SIG_ERR) {
- pr_err("cannot set signal: %s\n", strerrno());
- ret = 1;
- goto out;
- }
-
-join_out:
- /* waiting for threads join... */
- for (n = 0; n < m.nr_threads; n++) {
- if (m.threads[n].tid) {
- pthread_join(m.threads[n].tid, NULL);
- if (m.threads[n].ret < 0)
- ret = m.threads[n].ret;
- }
- }
-
- /* print final result */
- mscp_stat_final();
-
-out:
- if (ctrl)
- ssh_sftp_close(ctrl);
-
- if (m.threads) {
- for (n = 0; n < m.nr_threads; n++) {
- struct mscp_thread *t = &m.threads[n];
- if (t->sftp)
- ssh_sftp_close(t->sftp);
- }
- }
-
- return ret;
-}
-
-void mscp_copy_thread_cleanup(void *arg)
-{
- struct mscp_thread *t = arg;
- t->finished = true;
-}
-
-void *mscp_copy_thread(void *arg)
-{
- struct mscp_thread *t = arg;
- sftp_session sftp = t->sftp;
- struct chunk *c;
-
- if (t->cpu > -1) {
- if (set_thread_affinity(pthread_self(), t->cpu) < 0)
- return NULL;
- }
-
- pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, NULL);
- pthread_setcanceltype(PTHREAD_CANCEL_DEFERRED, NULL);
- pthread_cleanup_push(mscp_copy_thread_cleanup, t);
-
- while (1) {
- LOCK_ACQUIRE_THREAD(&m.chunk_lock);
- c = chunk_acquire(&m.chunk_list);
- LOCK_RELEASE_THREAD();
-
- if (!c)
- break; /* no more chunks */
-
- if ((t->ret = chunk_prepare(c, sftp)) < 0)
- break;
-
- if ((t->ret = chunk_copy(c, sftp, m.nr_ahead, m.buf_sz, &t->done)) < 0)
- break;
- }
-
- pthread_cleanup_pop(1);
-
- if (t->ret < 0)
- pr_err("copy failed: chunk %s 0x%010lx-0x%010lx\n",
- c->f->src_path, c->off, c->off + c->len);
-
- return NULL;
-}
-
-
-/* progress bar-related functions */
-
-double calculate_timedelta(struct timeval *b, struct timeval *a)
-{
- double sec, usec;
-
- if (a->tv_usec < b->tv_usec) {
- a->tv_usec += 1000000;
- a->tv_sec--;
- }
-
- sec = a->tv_sec - b->tv_sec;
- usec = a->tv_usec - b->tv_usec;
- sec += usec / 1000000;
-
- return sec;
-}
-
-double calculate_bps(size_t diff, struct timeval *b, struct timeval *a)
-{
- return (double)diff / calculate_timedelta(b, a);
-}
-
-char *calculate_eta(size_t remain, size_t diff, struct timeval *b, struct timeval *a)
-{
- static char buf[16];
- double elapsed = calculate_timedelta(b, a);
- double eta;
-
- if (diff == 0)
- snprintf(buf, sizeof(buf), "--:-- ETA");
- else {
- eta = remain / (diff / elapsed);
- snprintf(buf, sizeof(buf), "%02d:%02d ETA",
- (int)floor(eta / 60), (int)round(eta) % 60);
- }
- return buf;
-}
-
-void print_progress_bar(double percent, char *suffix)
-{
- int n, thresh, bar_width;
- struct winsize ws;
- char buf[128];
-
- /*
- * [=======> ] XX% SUFFIX
- */
-
- buf[0] = '\0';
-
- if (ioctl(STDOUT_FILENO, TIOCGWINSZ, &ws) < 0)
- return; /* XXX */
- bar_width = min(sizeof(buf), ws.ws_col) - strlen(suffix) - 7;
-
- memset(buf, 0, sizeof(buf));
- if (bar_width > 8) {
- thresh = floor(bar_width * (percent / 100)) - 1;
-
- for (n = 1; n < bar_width - 1; n++) {
- if (n <= thresh)
- buf[n] = '=';
- else
- buf[n] = ' ';
- }
- buf[thresh] = '>';
- buf[0] = '[';
- buf[bar_width - 1] = ']';
- snprintf(buf + bar_width, sizeof(buf) - bar_width,
- " %3d%% ", (int)floor(percent));
- }
-
- pprint1("%s%s", buf, suffix);
-}
+ if ((t = validate_targets(argv + optind, i)) == NULL)
+ return -1;
-void print_progress(struct timeval *b, struct timeval *a,
- size_t total, size_t last, size_t done)
-{
- char *bps_units[] = { "B/s ", "KB/s", "MB/s", "GB/s" };
- char *byte_units[] = { "B ", "KB", "MB", "GB", "TB", "PB" };
- char suffix[128];
- int bps_u, byte_tu, byte_du;
- size_t total_round, done_round;
- int percent;
- double bps;
-
-#define array_size(a) (sizeof(a) / sizeof(a[0]))
-
- if (total <= 0) {
- pprint1("total 0 byte transferred");
- return; /* copy 0-byte file(s) */
+ if (t[0].remote) {
+ /* copy remote to local */
+ o.direction = MSCP_DIRECTION_R2L;
+ remote = t[0].remote;
+ } else {
+ /* copy local to remote */
+ o.direction = MSCP_DIRECTION_L2R;
+ remote = t[i - 1].remote;
}
- total_round = total;
- for (byte_tu = 0; total_round > 1000 && byte_tu < array_size(byte_units) - 1;
- byte_tu++)
- total_round /= 1024;
-
- bps = calculate_bps(done - last, b, a);
- for (bps_u = 0; bps > 1000 && bps_u < array_size(bps_units); bps_u++)
- bps /= 1000;
-
- percent = floor(((double)(done) / (double)total) * 100);
-
- done_round = done;
- for (byte_du = 0; done_round > 1000 && byte_du < array_size(byte_units) - 1;
- byte_du++)
- done_round /= 1024;
-
- snprintf(suffix, sizeof(suffix), "%4lu%s/%lu%s %6.1f%s %s",
- done_round, byte_units[byte_du], total_round, byte_units[byte_tu],
- bps, bps_units[bps_u], calculate_eta(total - done, done - last, b, a));
-
- print_progress_bar(percent, suffix);
-}
-
-
-struct mscp_stat {
- struct timeval start, before, after;
- size_t total;
- size_t last;
- size_t done;
-} s;
-
-void mscp_stat_handler(int signum)
-{
- int n;
+ if ((m = mscp_init(remote, &o)) == NULL)
+ return -1;
- for (s.done = 0, n = 0; n < m.nr_threads; n++)
- s.done += m.threads[n].done;
+ if (mscp_connect(m) < 0)
+ return -1;
- gettimeofday(&s.after, NULL);
- if (signum == SIGALRM) {
- alarm(1);
- print_progress(&s.before, &s.after, s.total, s.last, s.done);
- s.before = s.after;
- s.last = s.done;
- } else {
- /* called from mscp_stat_final. calculate progress from the beginning */
- print_progress(&s.start, &s.after, s.total, 0, s.done);
- pprint(1, "\n"); /* this is final output. */
+ for (n = 0; n < i - 1; n++) {
+ if (mscp_add_src_path(m, t[n].path) < 0)
+ return -1;
}
-}
-int mscp_stat_init()
-{
- struct file *f;
+ if (mscp_set_dst_path(m, t[i - 1].path) < 0)
+ return -1;
- memset(&s, 0, sizeof(s));
- list_for_each_entry(f, &m.file_list, list) {
- s.total += f->size;
- }
+ if (mscp_prepare(m) < 0)
+ return -1;
- if (signal(SIGALRM, mscp_stat_handler) == SIG_ERR) {
- pr_err("signal: %s\n", strerrno());
+ if (mscp_start(m) < 0)
return -1;
- }
- gettimeofday(&s.start, NULL);
- s.before = s.start;
- alarm(1);
+ mscp_cleanup(m);
+ mscp_free(m);
return 0;
}
-
-void mscp_stat_final()
-{
- alarm(0);
- mscp_stat_handler(0);
-}
diff --git a/src/mscp.c b/src/mscp.c
index 2a2119a..f1af1b7 100644
--- a/src/mscp.c
+++ b/src/mscp.c
@@ -56,6 +56,14 @@ struct src {
#define DEFAULT_MIN_CHUNK_SZ (64 << 20) /* 64MB */
#define DEFAULT_NR_AHEAD 32
#define DEFAULT_BUF_SZ 16384
+/* XXX: we use 16384 byte buffer pointed by
+ * https://api.libssh.org/stable/libssh_tutor_sftp.html. The larget
+ * read length from sftp_async_read is 65536 byte. Read sizes larger
+ * than 65536 cause a situation where data remainds but
+ * sftp_async_read returns 0.
+ */
+
+#define non_null_string(s) (s[0] != '\0')
static int expand_coremask(const char *coremask, int **cores, int *nr_cores)
{
@@ -125,9 +133,9 @@ static int default_nr_threads()
static int validate_and_set_defaut_params(struct mscp_opts *o)
{
- /* set default values */
- if (!(o->direct == MSCP_DIRECT_L2R || o->direct == MSCP_DIRECT_R2L)) {
- pr_err("invalid direction: %d\n", o->direct);
+ if (!(o->direction == MSCP_DIRECTION_L2R ||
+ o->direction == MSCP_DIRECTION_R2L)) {
+ pr_err("invalid copy direction: %d\n", o->direction);
return -1;
}
@@ -145,15 +153,36 @@ static int validate_and_set_defaut_params(struct mscp_opts *o)
if (o->min_chunk_sz == 0)
o->min_chunk_sz = DEFAULT_MIN_CHUNK_SZ;
+ else {
+ if (o->min_chunk_sz < getpagesize() ||
+ o->min_chunk_sz % getpagesize() != 0) {
+ pr_err("min chunk size must be "
+ "larget than and multiple of page size %d: %lu\n",
+ getpagesize(), o->min_chunk_sz);
+ return -1;
+ }
+ }
- if (o->max_chunk_sz && o->min_chunk_sz > o->max_chunk_sz) {
- pr_err("smaller max chunk size than min chunk size: %lu < %lu\n",
- o->max_chunk_sz, o->min_chunk_sz);
- return -1;
+ if (o->max_chunk_sz) {
+ if (o->max_chunk_sz < getpagesize() ||
+ o->max_chunk_sz % getpagesize() != 0) {
+ pr_err("min chunk size must be "
+ "larget than and multiple of page size %d: %lu\n",
+ getpagesize(), o->max_chunk_sz);
+ }
+ if (o->min_chunk_sz > o->max_chunk_sz) {
+ pr_err("smaller max chunk size than min chunk size: %lu < %lu\n",
+ o->max_chunk_sz, o->min_chunk_sz);
+ return -1;
+ }
}
if (o->buf_sz == 0)
o->buf_sz = DEFAULT_BUF_SZ;
+ else if (o->buf_sz == 0) {
+ pr_err("invalid buf size: %lu\n", o->buf_sz);
+ return -1;
+ }
return 0;
}
@@ -169,7 +198,8 @@ struct mscp *mscp_init(const char *remote_host, struct mscp_opts *opts)
return NULL;
}
- validate_and_set_defaut_params(opts);
+ if (validate_and_set_defaut_params(opts) < 0)
+ goto free_out;
memset(m, 0, sizeof(*m));
INIT_LIST_HEAD(&m->src_list);
@@ -192,11 +222,17 @@ struct mscp *mscp_init(const char *remote_host, struct mscp_opts *opts)
}
m->opts = opts;
- m->ssh_opts.login_name = opts->ssh_login_name;
- m->ssh_opts.port = opts->ssh_port;
- m->ssh_opts.identity = opts->ssh_identity;
- m->ssh_opts.cipher = opts->ssh_cipher_spec;
- m->ssh_opts.hmac = opts->ssh_hmac_spec;
+ if (non_null_string(opts->ssh_login_name))
+ m->ssh_opts.login_name = opts->ssh_login_name;
+ if (non_null_string(opts->ssh_port))
+ m->ssh_opts.port = opts->ssh_port;
+ if (non_null_string(opts->ssh_identity))
+ m->ssh_opts.identity = opts->ssh_identity;
+ if (non_null_string(opts->ssh_cipher_spec))
+ m->ssh_opts.cipher = opts->ssh_cipher_spec;
+ if (non_null_string(opts->ssh_hmac_spec))
+ m->ssh_opts.hmac = opts->ssh_hmac_spec;
+
m->ssh_opts.compress = opts->ssh_compress_level;
m->ssh_opts.debuglevel = opts->ssh_debug_level;
m->ssh_opts.no_hostkey_check = opts->ssh_no_hostkey_check;
@@ -249,7 +285,11 @@ int mscp_set_dst_path(struct mscp *m, const char *dst_path)
return -1;
}
- strncpy(m->dst_path, dst_path, PATH_MAX);
+ if (!non_null_string(dst_path))
+ strncpy(m->dst_path, ".", 1);
+ else
+ strncpy(m->dst_path, dst_path, PATH_MAX);
+
return 0;
}
@@ -262,17 +302,17 @@ int mscp_prepare(struct mscp *m)
struct src *s;
mstat ss, ds;
- switch (m->opts->direct) {
- case MSCP_DIRECT_L2R:
+ switch (m->opts->direction) {
+ case MSCP_DIRECTION_L2R:
src_sftp = NULL;
dst_sftp = m->first;
break;
- case MSCP_DIRECT_R2L:
+ case MSCP_DIRECTION_R2L:
src_sftp = m->first;
dst_sftp = NULL;
break;
default:
- pr_err("invalid mscp direction: %d\n", m->opts->direct);
+ pr_err("invalid copy direction: %d\n", m->opts->direction);
return -1;
}
@@ -448,12 +488,12 @@ void *mscp_copy_thread(void *arg)
struct mscp *m = t->m;
struct chunk *c;
- switch (m->opts->direct) {
- case MSCP_DIRECT_L2R:
+ switch (m->opts->direction) {
+ case MSCP_DIRECTION_L2R:
src_sftp = NULL;
dst_sftp = t->sftp;
break;
- case MSCP_DIRECT_R2L:
+ case MSCP_DIRECTION_R2L:
src_sftp = t->sftp;
dst_sftp = NULL;
break;
diff --git a/src/mscp.h b/src/mscp.h
index 705c9fc..ccb57ca 100644
--- a/src/mscp.h
+++ b/src/mscp.h
@@ -3,30 +3,37 @@
#include <stdbool.h>
-#define MSCP_DIRECT_L2R 1
-#define MSCP_DIRECT_R2L 2
+#define MSCP_DIRECTION_L2R 1
+#define MSCP_DIRECTION_R2L 2
+
+#define MSCP_MAX_COREMASK_STR 64
+#define MSCP_MAX_LOGIN_NAME 64
+#define MSCP_MAX_PORT_STR 32
+#define MSCP_MAX_IDENTITY_PATH PATH_MAX
+#define MSCP_MAX_CIPHER_STR 32
+#define MSCP_MAX_HMACP_STR 32
struct mscp_opts {
/* mscp options */
- int direct; /* MSCP_DIRECT_ */
+ int direction; /* MSCP_DIRECTION_ */
int nr_threads;
int nr_ahead;
size_t min_chunk_sz;
size_t max_chunk_sz;
size_t buf_sz;
- char coremask[64];
+ char coremask[MSCP_MAX_COREMASK_STR];
int verbose_level;
bool quiet;
bool dryrun;
/* ssh options */
- char ssh_login_name[64];
- char ssh_port[32];
- char ssh_identity[PATH_MAX];
- char ssh_cipher_spec[64];
- char ssh_hmac_spec[32];
+ char ssh_login_name[MSCP_MAX_LOGIN_NAME];
+ char ssh_port[MSCP_MAX_PORT_STR];
+ char ssh_identity[MSCP_MAX_IDENTITY_PATH];
+ char ssh_cipher_spec[MSCP_MAX_CIPHER_STR];
+ char ssh_hmac_spec[MSCP_MAX_HMACP_STR];
int ssh_debug_level;
int ssh_compress_level;
bool ssh_no_hostkey_check;
diff --git a/src/path.c b/src/path.c
index 4e41203..dc6cac3 100644
--- a/src/path.c
+++ b/src/path.c
@@ -139,6 +139,8 @@ static int src2dst_path(const char *src_path, const char *src_file_path,
snprintf(dst_file_path, len, "%s/%s",
dst_path, src_file_path + strlen(src_path) + 1);
+ pprint3("file: %s -> %s\n", src_file_path, dst_file_path);
+
return 0;
}
@@ -266,7 +268,7 @@ static int touch_dst_path(struct path *p, sftp_session sftp)
strncpy(path, p->dst_path, sizeof(path));
/* mkdir -p.
- * XXX: this may be slow when dst is the remote side. need speed-up. */
+ * XXX: this may be slow when dst is the remote side. need speed-up. */
for (needle = strchr(path + 1, '/'); needle; needle = strchr(needle + 1, '/')) {
*needle = '\0';
@@ -290,12 +292,10 @@ static int touch_dst_path(struct path *p, sftp_session sftp)
}
/* open file with O_TRUNC to set file size 0 */
- mode = O_WRONLY|O_CREAT|O_TRUNC;
- h = mscp_open(p->dst_path, mode, S_IRUSR|S_IWUSR, 0, sftp);
- if (mscp_open_is_failed(h)) {
- pr_err("open %s: %s\n", p->dst_path, mscp_strerror(sftp));
+ h = mscp_open(p->dst_path, O_WRONLY|O_CREAT|O_TRUNC, S_IRUSR|S_IWUSR, 0, sftp);
+ if (mscp_open_is_failed(h))
return -1;
- }
+
mscp_close(h);
return 0;
@@ -348,8 +348,8 @@ static int copy_chunk_l2r(struct chunk *c, int fd, sftp_file sf,
reqs[idx].len = sftp_async_write(sf, read_to_buf, reqs[idx].len, &fd,
&reqs[idx].id);
if (reqs[idx].len < 0) {
- pr_err("sftp_async_write: %d or %s\n",
- sftp_get_error(sf->sftp), strerrno());
+ pr_err("sftp_async_write: %s or %s\n",
+ sftp_get_ssh_error(sf->sftp), strerrno());
return -1;
}
thrown -= reqs[idx].len;
@@ -358,7 +358,8 @@ static int copy_chunk_l2r(struct chunk *c, int fd, sftp_file sf,
for (idx = 0; remaind > 0; idx = (idx + 1) % nr_ahead) {
ret = sftp_async_write_end(sf, reqs[idx].id, 1);
if (ret != SSH_OK) {
- pr_err("sftp_async_write_end: %d\n", sftp_get_error(sf->sftp));
+ pr_err("sftp_async_write_end: %s\n",
+ sftp_get_ssh_error(sf->sftp));
return -1;
}
@@ -375,8 +376,8 @@ static int copy_chunk_l2r(struct chunk *c, int fd, sftp_file sf,
reqs[idx].len = sftp_async_write(sf, read_to_buf, reqs[idx].len, &fd,
&reqs[idx].id);
if (reqs[idx].len < 0) {
- pr_err("sftp_async_write: %d or %s\n",
- sftp_get_error(sf->sftp), strerrno());
+ pr_err("sftp_async_write: %s or %s\n",
+ sftp_get_ssh_error(sf->sftp), strerrno());
return -1;
}
thrown -= reqs[idx].len;
@@ -485,7 +486,7 @@ int copy_chunk(struct chunk *c, sftp_session src_sftp, sftp_session dst_sftp,
/* open src */
flags = O_RDONLY;
mode = S_IRUSR;
- s = mscp_open(c->p->path, mode, flags, c->off, src_sftp);
+ s = mscp_open(c->p->path, flags, mode, c->off, src_sftp);
if (mscp_open_is_failed(s)) {
mscp_close(d);
return -1;
@@ -494,7 +495,7 @@ int copy_chunk(struct chunk *c, sftp_session src_sftp, sftp_session dst_sftp,
/* open dst */
flags = O_WRONLY;
mode = S_IRUSR|S_IWUSR;
- d = mscp_open(c->p->dst_path, mode, flags, c->off, dst_sftp);
+ d = mscp_open(c->p->dst_path, flags, mode, c->off, dst_sftp);
if (mscp_open_is_failed(d))
return -1;
@@ -506,7 +507,7 @@ int copy_chunk(struct chunk *c, sftp_session src_sftp, sftp_session dst_sftp,
if (refcnt_dec(&c->p->refcnt) == 0) {
c->p->state = FILE_STATE_DONE;
- mscp_chmod(c->p->path, c->p->mode, dst_sftp);
+ mscp_chmod(c->p->dst_path, c->p->mode, dst_sftp);
pprint2("copy done: %s\n", c->p->path);
}
diff --git a/src/path.h b/src/path.h
index 1fa2ebf..2672f51 100644
--- a/src/path.h
+++ b/src/path.h
@@ -98,14 +98,15 @@ static mdir *mscp_opendir(const char *path, sftp_session sftp)
if (sftp) {
d->r = sftp_opendir(sftp, path);
if (!d->r) {
- pr_err("sftp_opendir: %s: %s\n", path, sftp_get_ssh_error(sftp));
+ pr_err("sftp_opendir '%s': %s\n",
+ path, sftp_get_ssh_error(sftp));
free(d);
return NULL;
}
} else {
d->l = opendir(path);
if (!d->l) {
- pr_err("opendir: %s: %s\n", path, strerrno());
+ pr_err("opendir '%s': %s\n", path, strerrno());
free(d);
return NULL;
}
@@ -227,7 +228,7 @@ struct mscp_file_handle {
};
typedef struct mscp_file_handle mfh;
-static mfh mscp_open(const char *path, mode_t mode, int flags, size_t off,
+static mfh mscp_open(const char *path, int flags, mode_t mode, size_t off,
sftp_session sftp)
{
mfh h;
@@ -238,12 +239,12 @@ static mfh mscp_open(const char *path, mode_t mode, int flags, size_t off,
if (sftp) {
h.sf = sftp_open(sftp, path, flags, mode);
if (!h.sf) {
- pr_err("sftp_open %s: %s\n", path, sftp_get_ssh_error(sftp));
+ pr_err("sftp_open '%s': %s\n", path, sftp_get_ssh_error(sftp));
return h;
}
if (sftp_seek64(h.sf, off) < 0) {
- pr_err("sftp_seek64 %s: %s\n", path, sftp_get_ssh_error(sftp));
+ pr_err("sftp_seek64 '%s': %s\n", path, sftp_get_ssh_error(sftp));
sftp_close(h.sf);
h.sf = NULL;
return h;
@@ -251,11 +252,11 @@ static mfh mscp_open(const char *path, mode_t mode, int flags, size_t off,
} else {
h.fd = open(path, flags, mode);
if (h.fd < 0) {
- pr_err("open %s: %s\n", path, strerrno());
+ pr_err("open '%s': %s\n", path, strerrno());
return h;
}
if (lseek(h.fd, off, SEEK_SET) < 0) {
- pr_err("lseek %s: %s\n", path, strerrno());
+ pr_err("lseek '%s': %s\n", path, strerrno());
close(h.fd);
h.fd = -1;
return h;
@@ -283,12 +284,12 @@ static int mscp_chmod(const char *path, mode_t mode, sftp_session sftp)
{
if (sftp) {
if (sftp_chmod(sftp, path, mode) < 0) {
- pr_err("sftp_chmod %s: %s\n", path, sftp_get_ssh_error(sftp));
+ pr_err("sftp_chmod '%s': %s\n", path, sftp_get_ssh_error(sftp));
return -1;
}
} else {
if (chmod(path, mode) < 0) {
- pr_err("chmod %s: %s\n", path, strerrno());
+ pr_err("chmod '%s': %s\n", path, strerrno());
return -1;
}
}
diff --git a/src/util.h b/src/util.h
index 774e80a..0f20249 100644
--- a/src/util.h
+++ b/src/util.h
@@ -4,6 +4,7 @@
#include <stdio.h>
#include <string.h>
#include <errno.h>
+#include <libgen.h>
#define likely(x) __builtin_expect(!!(x), 1)
#define unlikely(x) __builtin_expect(!!(x), 0)
@@ -19,8 +20,8 @@
__func__, ##__VA_ARGS__)
#define pr_err(fmt, ...) fprintf(stderr, "\x1b[1m\x1b[31m" \
- "ERR:%s():\x1b[0m " fmt, \
- __func__, ##__VA_ARGS__)
+ "ERR:%s:%d:%s():\x1b[0m " fmt, \
+ basename(__FILE__), __LINE__, __func__, ##__VA_ARGS__)
#ifdef DEBUG
#define pr_debug(fmt, ...) fprintf(stderr, "\x1b[1m\x1b[33m" \