| Age | Commit message (Collapse) | Author |
|---|
|
Co-authored-by: crowlkats <crowlkats@toaxl.com>
|
|
|
|
|
|
Fixes [current
failure](https://github.com/denoland/deno/actions/runs/9247491137/job/25436409566)
|
|
(#23910)
If `@@asyncIterator` is `null` or `undefined`, it should ignores and
fallback to `@@iterator`.
Tests have been merged into WPT.
https://github.com/web-platform-tests/wpt/pull/46374
The proposal of `ReadableStream.from` uses TC39 [GetIterator][] and
[GetMethod][] within it.
GetMethod treats null as undefined.
So if `@@asyncIterator` is `null` it should be ignored and fallback to
`@@iterator`.
[GetIterator]: https://tc39.es/ecma262/#sec-getiterator
[GetMethod]: https://tc39.es/ecma262/#sec-getmethod
```bash
> deno eval "ReadableStream.from({ [Symbol.asyncIterator]: null, [Symbol.iterator]: () => ({ next: () => ({ done: true }) }) }).pipeTo(new WritableStream())"
error: Uncaught (in promise) TypeError: obj[SymbolAsyncIterator] is not a function
ReadableStream.from({ [Symbol.asyncIterator]: null, [Symbol.iterator]: () => ({ next: () => ({ done: true }) }) }).pipeTo(new WritableStream())
^
at getIterator (ext:deno_web/06_streams.js:5105:38)
at Function.from (ext:deno_web/06_streams.js:5207:22)
at file:///D:/work/js/deno/tests/wpt/suite/$deno$eval:1:16
```
---------
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
|
|
Closes #23790
|
|
(#23642)
See https://github.com/whatwg/webidl/pull/1387 for context.
There are new WPT tests for this change in
https://github.com/web-platform-tests/wpt/pull/44456. They pass on my
local machine, but I'm not sure if I should update the WPT submodule for
all of Deno as part of this PR?
Fixes #22389
---------
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.
|
|
It's best that this only gets merged with the latest version of the
suite, so there's little difference between the `ci` and `wpt_epoch`
workflows. This should make troubleshooting easier.
|
|
Should fix some of the current issues with the `wpt_epoch` workflow.
See
https://github.com/denoland/deno/actions/runs/8460701853/job/23179358486
---------
Co-authored-by: crowlkats <crowlkats@toaxl.com>
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
|
|
As discussed with @mmastrac. I'll move `tools/wpt` to `tests/wpt` in a
follow-up PR.
---------
Co-authored-by: Matt Mastracci <matthew@mastracci.com>
|
