summaryrefslogtreecommitdiff
path: root/cli
diff options
context:
space:
mode:
Diffstat (limited to 'cli')
-rw-r--r--cli/lsp/tsc.rs4
-rw-r--r--cli/tests/lsp_tests.rs14
2 files changed, 5 insertions, 13 deletions
diff --git a/cli/lsp/tsc.rs b/cli/lsp/tsc.rs
index 7145d00c2..8a83839bf 100644
--- a/cli/lsp/tsc.rs
+++ b/cli/lsp/tsc.rs
@@ -2007,6 +2007,10 @@ impl CompletionEntryDetails {
documentation,
command,
additional_text_edits,
+ // NOTE(bartlomieju): it's not entirely clear to me why we need to do that,
+ // but when `completionItem/resolve` is called, we get a list of commit chars
+ // even though we might have returned an empty list in `completion` request.
+ commit_characters: None,
..original_item.clone()
})
}
diff --git a/cli/tests/lsp_tests.rs b/cli/tests/lsp_tests.rs
index 48f354248..1a03d8217 100644
--- a/cli/tests/lsp_tests.rs
+++ b/cli/tests/lsp_tests.rs
@@ -3958,12 +3958,6 @@ export class DuckConfig {
},
"newText": "import { foo } from \"./b.ts\";\n\n"
}
- ],
- "commitCharacters": [
- ".",
- ",",
- ";",
- "("
]
}))
);
@@ -4077,13 +4071,7 @@ export class DuckConfig {
"sortText": "11",
"filterText": "type=\"$1\"",
"insertText": "type=\"$1\"",
- "insertTextFormat": 2,
- "commitCharacters": [
- ".",
- ",",
- ";",
- "("
- ]
+ "insertTextFormat": 2
}))
);
}