diff options
Diffstat (limited to 'cli')
| -rw-r--r-- | cli/build.rs | 5 | ||||
| -rw-r--r-- | cli/tests/unit_node/module_test.ts | 17 |
2 files changed, 17 insertions, 5 deletions
diff --git a/cli/build.rs b/cli/build.rs index 305d622a6..3e74a3ff3 100644 --- a/cli/build.rs +++ b/cli/build.rs @@ -38,10 +38,7 @@ mod ts { fn op_build_info(state: &mut OpState) -> Value { let build_specifier = "asset:///bootstrap.ts"; - let node_built_in_module_names = SUPPORTED_BUILTIN_NODE_MODULES - .iter() - .map(|p| p.module_name()) - .collect::<Vec<&str>>(); + let node_built_in_module_names = SUPPORTED_BUILTIN_NODE_MODULES.to_vec(); let build_libs = state.borrow::<Vec<&str>>(); json!({ "buildSpecifier": build_specifier, diff --git a/cli/tests/unit_node/module_test.ts b/cli/tests/unit_node/module_test.ts index 3a675c7a1..9818f4766 100644 --- a/cli/tests/unit_node/module_test.ts +++ b/cli/tests/unit_node/module_test.ts @@ -1,6 +1,6 @@ // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license. -import { Module } from "node:module"; +import { createRequire, Module } from "node:module"; import { assert, assertEquals, @@ -58,3 +58,18 @@ Deno.test("[node/module _nodeModulePaths] prevents duplicate root /node_modules" "Missing root 'node_modules' directory", ); }); + +Deno.test("Built-in Node modules have `node:` prefix", () => { + let thrown = false; + try { + // @ts-ignore We want to explicitly test wrong call signature + createRequire(); + } catch (e) { + thrown = true; + const stackLines = e.stack.split("\n"); + // Assert that built-in node modules have `node:<mod_name>` specifiers. + assert(stackLines.some((line: string) => line.includes("(node:module:"))); + } + + assert(thrown); +}); |