summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
Diffstat
-rw-r--r--core/ops.rs2
-rw-r--r--core/runtime.rs2
-rw-r--r--serde_v8/magic/buffer.rs6
-rw-r--r--serde_v8/magic/bytestring.rs2
-rw-r--r--serde_v8/magic/detached_buffer.rs2
-rw-r--r--serde_v8/magic/global.rs2
-rw-r--r--serde_v8/magic/string_or_buffer.rs2
-rw-r--r--serde_v8/magic/transl8.rs4
-rw-r--r--serde_v8/magic/u16string.rs2
-rw-r--r--serde_v8/magic/value.rs2
-rw-r--r--serde_v8/ser.rs4
-rw-r--r--serde_v8/serializable.rs6
12 files changed, 19 insertions, 17 deletions
diff --git a/core/ops.rs b/core/ops.rs
index a96681eb5..d22a703bd 100644
--- a/core/ops.rs
+++ b/core/ops.rs
@@ -99,7 +99,7 @@ pub enum OpResult {
impl OpResult {
pub fn to_v8<'a>(
- &self,
+ &mut self,
scope: &mut v8::HandleScope<'a>,
) -> Result<v8::Local<'a, v8::Value>, serde_v8::Error> {
match self {
diff --git a/core/runtime.rs b/core/runtime.rs
index 366e834a2..47777099c 100644
--- a/core/runtime.rs
+++ b/core/runtime.rs
@@ -1944,7 +1944,7 @@ impl JsRuntime {
// and then each tuple is used to resolve or reject promises
let mut args = vec![];
- for (promise_id, resp) in results.into_iter() {
+ for (promise_id, mut resp) in results.into_iter() {
args.push(v8::Integer::new(scope, promise_id).into());
args.push(resp.to_v8(scope).unwrap());
}
diff --git a/serde_v8/magic/buffer.rs b/serde_v8/magic/buffer.rs
index db50e3896..eec027e17 100644
--- a/serde_v8/magic/buffer.rs
+++ b/serde_v8/magic/buffer.rs
@@ -103,7 +103,7 @@ impl From<Vec<u8>> for ZeroCopyBuf {
impl ToV8 for ZeroCopyBuf {
fn to_v8<'a>(
- &self,
+ &mut self,
scope: &mut v8::HandleScope<'a>,
) -> Result<v8::Local<'a, v8::Value>, crate::Error> {
let buf: Box<[u8]> = match self {
@@ -112,7 +112,9 @@ impl ToV8 for ZeroCopyBuf {
value.into()
}
Self::Temp(_) => unreachable!(),
- Self::ToV8(x) => x.lock().unwrap().take().expect("ZeroCopyBuf was empty"),
+ Self::ToV8(x) => {
+ x.get_mut().unwrap().take().expect("ZeroCopyBuf was empty")
+ }
};
if buf.is_empty() {
diff --git a/serde_v8/magic/bytestring.rs b/serde_v8/magic/bytestring.rs
index 5580fdced..ebf96031f 100644
--- a/serde_v8/magic/bytestring.rs
+++ b/serde_v8/magic/bytestring.rs
@@ -32,7 +32,7 @@ const _: () =
impl ToV8 for ByteString {
fn to_v8<'a>(
- &self,
+ &mut self,
scope: &mut v8::HandleScope<'a>,
) -> Result<v8::Local<'a, v8::Value>, crate::Error> {
let v =
diff --git a/serde_v8/magic/detached_buffer.rs b/serde_v8/magic/detached_buffer.rs
index 4e33de32c..b35d4f66d 100644
--- a/serde_v8/magic/detached_buffer.rs
+++ b/serde_v8/magic/detached_buffer.rs
@@ -41,7 +41,7 @@ impl DerefMut for DetachedBuffer {
impl ToV8 for DetachedBuffer {
fn to_v8<'a>(
- &self,
+ &mut self,
scope: &mut v8::HandleScope<'a>,
) -> Result<v8::Local<'a, v8::Value>, crate::Error> {
let buffer = v8::ArrayBuffer::with_backing_store(scope, &self.0.store);
diff --git a/serde_v8/magic/global.rs b/serde_v8/magic/global.rs
index 942394067..4f7b70fdf 100644
--- a/serde_v8/magic/global.rs
+++ b/serde_v8/magic/global.rs
@@ -23,7 +23,7 @@ impl From<Global> for v8::Global<v8::Value> {
impl ToV8 for Global {
fn to_v8<'a>(
- &self,
+ &mut self,
scope: &mut v8::HandleScope<'a>,
) -> Result<v8::Local<'a, v8::Value>, crate::Error> {
Ok(v8::Local::new(scope, self.v8_value.clone()))
diff --git a/serde_v8/magic/string_or_buffer.rs b/serde_v8/magic/string_or_buffer.rs
index 78954e60c..aa7e26d2b 100644
--- a/serde_v8/magic/string_or_buffer.rs
+++ b/serde_v8/magic/string_or_buffer.rs
@@ -25,7 +25,7 @@ impl Deref for StringOrBuffer {
impl ToV8 for StringOrBuffer {
fn to_v8<'a>(
- &self,
+ &mut self,
scope: &mut v8::HandleScope<'a>,
) -> Result<v8::Local<'a, v8::Value>, crate::Error> {
match self {
diff --git a/serde_v8/magic/transl8.rs b/serde_v8/magic/transl8.rs
index 2336b5b27..9beb9eade 100644
--- a/serde_v8/magic/transl8.rs
+++ b/serde_v8/magic/transl8.rs
@@ -14,7 +14,7 @@ pub(crate) trait MagicType {
pub(crate) trait ToV8 {
fn to_v8<'a>(
- &self,
+ &mut self,
scope: &mut v8::HandleScope<'a>,
) -> Result<v8::Local<'a, v8::Value>, crate::Error>;
}
@@ -104,7 +104,7 @@ pub(crate) unsafe fn opaque_recv<T: ?Sized>(ptr: &T) -> u64 {
}
/// Transmutes an "opaque" ptr back into a reference
-pub(crate) unsafe fn opaque_deref<'a, T>(ptr: u64) -> &'a T {
+pub(crate) unsafe fn opaque_deref_mut<'a, T>(ptr: u64) -> &'a mut T {
std::mem::transmute(ptr as usize)
}
diff --git a/serde_v8/magic/u16string.rs b/serde_v8/magic/u16string.rs
index 1e36879a4..22868ccfb 100644
--- a/serde_v8/magic/u16string.rs
+++ b/serde_v8/magic/u16string.rs
@@ -8,7 +8,7 @@ impl_magic!(U16String);
impl ToV8 for U16String {
fn to_v8<'a>(
- &self,
+ &mut self,
scope: &mut v8::HandleScope<'a>,
) -> Result<v8::Local<'a, v8::Value>, crate::Error> {
let maybe_v =
diff --git a/serde_v8/magic/value.rs b/serde_v8/magic/value.rs
index 5d844fbda..651e75263 100644
--- a/serde_v8/magic/value.rs
+++ b/serde_v8/magic/value.rs
@@ -29,7 +29,7 @@ impl<'s> From<Value<'s>> for v8::Local<'s, v8::Value> {
impl ToV8 for Value<'_> {
fn to_v8<'a>(
- &self,
+ &mut self,
_scope: &mut v8::HandleScope<'a>,
) -> Result<v8::Local<'a, v8::Value>, crate::Error> {
// SAFETY: not fully safe, since lifetimes are detached from original scope
diff --git a/serde_v8/ser.rs b/serde_v8/ser.rs
index 3bd71a02d..0c6c52da0 100644
--- a/serde_v8/ser.rs
+++ b/serde_v8/ser.rs
@@ -7,7 +7,7 @@ use std::cell::RefCell;
use crate::error::{Error, Result};
use crate::keys::v8_struct_key;
use crate::magic::transl8::MAGIC_FIELD;
-use crate::magic::transl8::{opaque_deref, opaque_recv, MagicType, ToV8};
+use crate::magic::transl8::{opaque_deref_mut, opaque_recv, MagicType, ToV8};
use crate::{
magic, ByteString, DetachedBuffer, StringOrBuffer, U16String, ZeroCopyBuf,
};
@@ -253,7 +253,7 @@ impl<'a, 'b, 'c, T: MagicType + ToV8> ser::SerializeStruct
fn end(self) -> JsResult<'a> {
// SAFETY: transerialization assumptions imply `T` is still alive.
- let x: &T = unsafe { opaque_deref(self.opaque) };
+ let x: &mut T = unsafe { opaque_deref_mut(self.opaque) };
let scope = &mut *self.scope.borrow_mut();
x.to_v8(scope)
}
diff --git a/serde_v8/serializable.rs b/serde_v8/serializable.rs
index 7820d02ec..f0198fafa 100644
--- a/serde_v8/serializable.rs
+++ b/serde_v8/serializable.rs
@@ -12,7 +12,7 @@ use crate::ZeroCopyBuf;
/// (and thus doesn't have to have generic outputs, etc...)
pub trait Serializable {
fn to_v8<'a>(
- &self,
+ &mut self,
scope: &mut v8::HandleScope<'a>,
) -> Result<v8::Local<'a, v8::Value>, crate::Error>;
}
@@ -20,7 +20,7 @@ pub trait Serializable {
/// Allows all implementors of `serde::Serialize` to implement Serializable
impl<T: serde::Serialize> Serializable for T {
fn to_v8<'a>(
- &self,
+ &mut self,
scope: &mut v8::HandleScope<'a>,
) -> Result<v8::Local<'a, v8::Value>, crate::Error> {
crate::to_v8(scope, self)
@@ -36,7 +36,7 @@ pub enum SerializablePkg {
impl SerializablePkg {
pub fn to_v8<'a>(
- &self,
+ &mut self,
scope: &mut v8::HandleScope<'a>,
) -> Result<v8::Local<'a, v8::Value>, crate::Error> {
match self {
generated by cgit v1.2.3 (git 2.25.1) at 2025-06-27 12:54:51 +0000