summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--cli/tests/node_compat/config.jsonc6
-rw-r--r--cli/tests/node_compat/test/parallel/test-child-process-exec-timeout-expire.js61
2 files changed, 4 insertions, 63 deletions
diff --git a/cli/tests/node_compat/config.jsonc b/cli/tests/node_compat/config.jsonc
index 62ab88e3d..b22d252e4 100644
--- a/cli/tests/node_compat/config.jsonc
+++ b/cli/tests/node_compat/config.jsonc
@@ -30,7 +30,8 @@
"test-child-process-exec-kill-throws.js",
"test-child-process-exec-maxbuf.js",
"test-child-process-exec-std-encoding.js",
- "test-child-process-exec-timeout-expire.js",
+ // TODO(bartlomieju): this test was flaky on macOS CI
+ // "test-child-process-exec-timeout-expire.js",
"test-child-process-exec-timeout-kill.js",
"test-child-process-exec-timeout-not-expired.js",
"test-child-process-execFile-promisified-abortController.js",
@@ -209,7 +210,8 @@
"test-child-process-exec-kill-throws.js",
"test-child-process-exec-maxbuf.js",
"test-child-process-exec-stdout-stderr-data-string.js",
- "test-child-process-exec-timeout-expire.js",
+ // TODO(bartlomieju): this test was flaky on macOS CI
+ // "test-child-process-exec-timeout-expire.js",
"test-child-process-exec-timeout-kill.js",
// TODO(bartlomieju): this test was flaky on macOS CI
// "test-child-process-execFile-promisified-abortController.js",
diff --git a/cli/tests/node_compat/test/parallel/test-child-process-exec-timeout-expire.js b/cli/tests/node_compat/test/parallel/test-child-process-exec-timeout-expire.js
deleted file mode 100644
index 67c4a7204..000000000
--- a/cli/tests/node_compat/test/parallel/test-child-process-exec-timeout-expire.js
+++ /dev/null
@@ -1,61 +0,0 @@
-// deno-fmt-ignore-file
-// deno-lint-ignore-file
-
-// Copyright Joyent and Node contributors. All rights reserved. MIT license.
-// Taken from Node 18.12.1
-// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually
-
-// TODO(PolarETech): The process.argv[3] check should be argv[2], and the
-// command passed to exec() should not need to include "run", "-A",
-// and "require.ts".
-
-'use strict';
-
-// Test exec() with a timeout that expires.
-
-const common = require('../common');
-const assert = require('assert');
-const cp = require('child_process');
-
-const {
- cleanupStaleProcess,
- logAfterTime,
- kExpiringChildRunTime,
- kExpiringParentTimer
-} = require('../common/child_process');
-
-if (process.argv[3] === 'child') {
- logAfterTime(kExpiringChildRunTime);
- return;
-}
-
-const cmd = `"${process.execPath}" run -A require.ts "${__filename}" child`;
-
-cp.exec(cmd, {
- timeout: kExpiringParentTimer,
-}, common.mustCall((err, stdout, stderr) => {
- console.log('[stdout]', stdout.trim());
- console.log('[stderr]', stderr.trim());
-
- let sigterm = 'SIGTERM';
- assert.strictEqual(err.killed, true);
- // TODO OpenBSD returns a null signal and 143 for code
- if (common.isOpenBSD) {
- assert.strictEqual(err.code, 143);
- sigterm = null;
- } else {
- assert.strictEqual(err.code, null);
- }
- // At least starting with Darwin Kernel Version 16.4.0, sending a SIGTERM to a
- // process that is still starting up kills it with SIGKILL instead of SIGTERM.
- // See: https://github.com/libuv/libuv/issues/1226
- if (common.isOSX)
- assert.ok(err.signal === 'SIGTERM' || err.signal === 'SIGKILL');
- else
- assert.strictEqual(err.signal, sigterm);
- assert.strictEqual(err.cmd, cmd);
- assert.strictEqual(stdout.trim(), '');
- assert.strictEqual(stderr.trim(), '');
-}));
-
-cleanupStaleProcess(__filename);