diff options
-rw-r--r-- | js/timers.ts | 10 | ||||
-rw-r--r-- | js/timers_test.ts | 54 |
2 files changed, 64 insertions, 0 deletions
diff --git a/js/timers.ts b/js/timers.ts index 1e8bb428d..ba9a653a8 100644 --- a/js/timers.ts +++ b/js/timers.ts @@ -181,6 +181,12 @@ function fireTimers(): void { export type Args = unknown[]; +function checkThis(thisArg: unknown): void { + if (thisArg !== null && thisArg !== undefined && thisArg !== window) { + throw new TypeError("Illegal invocation"); + } +} + function setTimer( cb: (...args: Args) => void, delay: number, @@ -226,6 +232,8 @@ export function setTimeout( delay: number, ...args: Args ): number { + // @ts-ignore + checkThis(this); return setTimer(cb, delay, args, false); } @@ -235,6 +243,8 @@ export function setInterval( delay: number, ...args: Args ): number { + // @ts-ignore + checkThis(this); return setTimer(cb, delay, args, true); } diff --git a/js/timers_test.ts b/js/timers_test.ts index cbdc6eaba..88c5ea5ca 100644 --- a/js/timers_test.ts +++ b/js/timers_test.ts @@ -177,3 +177,57 @@ test(async function timeoutCallbackThis(): Promise<void> { setTimeout(obj.foo, 1); await promise; }); + +test(async function timeoutBindThis(): Promise<void> { + function noop(): void {} + + const thisCheckPassed = [null, undefined, window, globalThis]; + + const thisCheckFailed = [ + 0, + "", + true, + false, + {}, + [], + "foo", + (): void => {}, + Object.prototype + ]; + + thisCheckPassed.forEach( + // eslint-disable-next-line @typescript-eslint/no-explicit-any + (thisArg: any): void => { + let hasThrown = 0; + try { + setTimeout.call(thisArg, noop, 1); + hasThrown = 1; + } catch (err) { + if (err instanceof TypeError) { + hasThrown = 2; + } else { + hasThrown = 3; + } + } + assertEquals(hasThrown, 1); + } + ); + + thisCheckFailed.forEach( + // eslint-disable-next-line @typescript-eslint/no-explicit-any + (thisArg: any): void => { + let hasThrown = 0; + try { + setTimeout.call(thisArg, noop, 1); + hasThrown = 1; + } catch (err) { + if (err instanceof TypeError) { + hasThrown = 2; + } else { + hasThrown = 3; + } + } + assertEquals(hasThrown, 2); + } + ); +}); |