diff options
-rw-r--r-- | cli/tests/testdata/npm/compare_globals/main.out | 1 | ||||
-rw-r--r-- | cli/tests/testdata/npm/compare_globals/main.ts | 2 | ||||
-rw-r--r-- | ext/node/global.rs | 11 |
3 files changed, 11 insertions, 3 deletions
diff --git a/cli/tests/testdata/npm/compare_globals/main.out b/cli/tests/testdata/npm/compare_globals/main.out index 31fcedda3..0e366fae7 100644 --- a/cli/tests/testdata/npm/compare_globals/main.out +++ b/cli/tests/testdata/npm/compare_globals/main.out @@ -25,3 +25,4 @@ false false bar bar +true diff --git a/cli/tests/testdata/npm/compare_globals/main.ts b/cli/tests/testdata/npm/compare_globals/main.ts index 8d3ae1ea0..6f7b9ef8e 100644 --- a/cli/tests/testdata/npm/compare_globals/main.ts +++ b/cli/tests/testdata/npm/compare_globals/main.ts @@ -48,3 +48,5 @@ globals.checkWindowGlobal(); (globalThis as any).foo = "bar"; console.log((globalThis as any).foo); console.log(globals.getFoo()); + +console.log(Reflect.ownKeys(globalThis).includes("console")); // non-enumerable keys are included diff --git a/ext/node/global.rs b/ext/node/global.rs index fd2f5a7cb..994155359 100644 --- a/ext/node/global.rs +++ b/ext/node/global.rs @@ -432,9 +432,14 @@ pub fn enumerator<'s>( }; let inner = v8::Local::new(scope, inner); - let Some(array) = - inner.get_property_names(scope, GetPropertyNamesArgs::default()) - else { + let Some(array) = inner.get_property_names( + scope, + GetPropertyNamesArgs { + mode: v8::KeyCollectionMode::OwnOnly, + property_filter: v8::PropertyFilter::ALL_PROPERTIES, + ..Default::default() + }, + ) else { return; }; |