diff options
author | Andy Hayden <andyhayden1@gmail.com> | 2019-06-08 04:46:57 -0700 |
---|---|---|
committer | Ryan Dahl <ry@tinyclouds.org> | 2019-06-08 07:46:57 -0400 |
commit | 5960e398ecab914effec821cc6da5f3a091fdb50 (patch) | |
tree | bb12c155ef59b725dcc0d7a32b757e47718cdaa1 /tools/target_test.py | |
parent | 4ea2df6759abf3a99e07fe720987805075c8a18b (diff) |
make tests quieter (#2468)
Don't mix every http request in with the tests output.
Don't print that the file servers are starting unless
-vv flag is passed.
Capture the output of run with run_output which returns
stdout, stderr and exit_code. Test against this rather
than relying on sys.exit.
Diffstat (limited to 'tools/target_test.py')
-rw-r--r-- | tools/target_test.py | 29 |
1 files changed, 17 insertions, 12 deletions
diff --git a/tools/target_test.py b/tools/target_test.py index 3f1ddb8b5..98eb4a0eb 100644 --- a/tools/target_test.py +++ b/tools/target_test.py @@ -2,7 +2,7 @@ import os import sys from test_util import DenoTestCase, run_tests -from util import executable_suffix, run, tests_path, run_output +from util import executable_suffix, tests_path, run, run_output class TestTarget(DenoTestCase): @@ -20,7 +20,7 @@ class TestTarget(DenoTestCase): "Test executable runs and exits with code 0." bin_file = os.path.join(self.build_dir, executable + executable_suffix) self.check_exists(bin_file) - run([bin_file]) + run([bin_file], quiet=True) def test_libdeno(self): self._test("libdeno_test") @@ -35,26 +35,31 @@ class TestTarget(DenoTestCase): self._test("deno_core_http_bench_test") def test_ts_library_builder(self): - run([ + result = run_output([ "node", "./node_modules/.bin/ts-node", "--project", "tools/ts_library_builder/tsconfig.json", "tools/ts_library_builder/test.ts" - ]) + ], + quiet=True) + self.assertEqual(result.code, 0) + assert "ts_library_builder ok" in result.out def test_no_color(self): t = os.path.join(tests_path, "no_color.js") - output = run_output([self.deno_exe, "run", t], - merge_env={"NO_COLOR": "1"}) - assert output.strip() == "noColor true" + result = run_output([self.deno_exe, "run", t], + merge_env={"NO_COLOR": "1"}, + quiet=True) + assert result.out.strip() == "noColor true" t = os.path.join(tests_path, "no_color.js") - output = run_output([self.deno_exe, "run", t]) - assert output.strip() == "noColor false" + result = run_output([self.deno_exe, "run", t], quiet=True) + assert result.out.strip() == "noColor false" def test_exec_path(self): cmd = [self.deno_exe, "run", "tests/exec_path.ts"] - output = run_output(cmd) - assert self.deno_exe in output.strip() + result = run_output(cmd, quiet=True) + assert self.deno_exe in result.out.strip() + self.assertEqual(result.code, 0) -if __name__ == "main": +if __name__ == "__main__": run_tests() |