diff options
| author | Ryan Dahl <ry@tinyclouds.org> | 2020-01-30 10:49:33 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-01-30 10:49:33 -0500 |
| commit | 2338e7679c8840314642dbf3ea838908f5f35d3c (patch) | |
| tree | fd8a56d12bc84167e306fb7fdf71a32ab86362ad /tools/http_benchmark.py | |
| parent | 51089836eb835d6b4cc03653dcb0b7a281017157 (diff) | |
Remove --current-thread flag (#3830)
This flag was added to evaluate performance relative to tokio's threaded
runtime. Although it's faster in the HTTP benchmark, it's clear the runtime
is not the only perf problem.
Removing this flag will simplify further refactors, in particular
adopting the #[tokio::main] macro. This will be done in a follow up.
Ultimately we expect to move to the current thread runtime with Isolates
pinned to specific threads, but that will be a much larger refactor. The
--current-thread just complicates that effort.
Diffstat (limited to 'tools/http_benchmark.py')
| -rwxr-xr-x | tools/http_benchmark.py | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/tools/http_benchmark.py b/tools/http_benchmark.py index 03f9f4365..d46d8a33d 100755 --- a/tools/http_benchmark.py +++ b/tools/http_benchmark.py @@ -42,17 +42,6 @@ def deno_tcp(deno_exe): return run(deno_cmd, port) -def deno_tcp_current_thread(deno_exe): - port = get_port() - deno_cmd = [ - deno_exe, "run", "--current-thread", "--allow-net", - "tools/deno_tcp.ts", - server_addr(port) - ] - print "http_benchmark testing DENO tcp (single-thread)." - return run(deno_cmd, port) - - def deno_http(deno_exe): port = get_port() deno_cmd = [ @@ -154,7 +143,6 @@ def http_benchmark(build_dir): return { # "deno_tcp" was once called "deno" "deno_tcp": deno_tcp(deno_exe), - "deno_tcp_current_thread": deno_tcp_current_thread(deno_exe), # "deno_http" was once called "deno_net_http" "deno_http": deno_http(deno_exe), "deno_proxy": deno_http_proxy(deno_exe, hyper_hello_exe), |