diff options
| author | Divy Srivastava <dj.srivastava23@gmail.com> | 2024-09-19 00:20:42 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-18 20:50:42 +0200 |
| commit | fd860260ad0fd72d638c4cc69ff45c25dbaafaa6 (patch) | |
| tree | 0add376973b7085460db21b1a609055909502880 /tests | |
| parent | f347e779e0d1321d19a61de67295e7bd5edc3083 (diff) | |
feat(lint): add `no-process-global` lint rule (#25709)
Closes https://github.com/denoland/deno/issues/25679
Diffstat (limited to 'tests')
4 files changed, 14 insertions, 9 deletions
diff --git a/tests/specs/lint/node_globals_no_duplicate_imports/__test__.jsonc b/tests/specs/lint/node_globals_no_duplicate_imports/__test__.jsonc index a632e896e..3feb6eaba 100644 --- a/tests/specs/lint/node_globals_no_duplicate_imports/__test__.jsonc +++ b/tests/specs/lint/node_globals_no_duplicate_imports/__test__.jsonc @@ -3,7 +3,8 @@ "steps": [ { "args": "run main.ts", - "output": "" + "output": "main.out", + "exitCode": 1 }, { "args": "lint main.ts", diff --git a/tests/specs/lint/node_globals_no_duplicate_imports/lint.out b/tests/specs/lint/node_globals_no_duplicate_imports/lint.out index b396e71eb..d9ff7f77e 100644 --- a/tests/specs/lint/node_globals_no_duplicate_imports/lint.out +++ b/tests/specs/lint/node_globals_no_duplicate_imports/lint.out @@ -1,9 +1,9 @@ error[no-node-globals]: NodeJS globals are not available in Deno --> [WILDCARD]main.ts:3:14 | -3 | const _foo = process.env.FOO; - | ^^^^^^^ - = hint: Add `import process from "node:process";` +3 | const _foo = setImmediate; + | ^^^^^^^^^^^^ + = hint: Add `import { setImmediate } from "node:timers";` docs: https://lint.deno.land/rules/no-node-globals @@ -11,9 +11,9 @@ error[no-node-globals]: NodeJS globals are not available in Deno error[no-node-globals]: NodeJS globals are not available in Deno --> [WILDCARD]main.ts:7:14 | -7 | const _bar = process.env.BAR; - | ^^^^^^^ - = hint: Add `import process from "node:process";` +7 | const _bar = setImmediate; + | ^^^^^^^^^^^^ + = hint: Add `import { setImmediate } from "node:timers";` docs: https://lint.deno.land/rules/no-node-globals diff --git a/tests/specs/lint/node_globals_no_duplicate_imports/main.out b/tests/specs/lint/node_globals_no_duplicate_imports/main.out new file mode 100644 index 000000000..56df10eba --- /dev/null +++ b/tests/specs/lint/node_globals_no_duplicate_imports/main.out @@ -0,0 +1,4 @@ +error: Uncaught (in promise) ReferenceError: setImmediate is not defined +const _foo = setImmediate; + ^ + at [WILDCARD]main.ts:3:14 diff --git a/tests/specs/lint/node_globals_no_duplicate_imports/main.ts b/tests/specs/lint/node_globals_no_duplicate_imports/main.ts index bff428d01..73ccb255e 100644 --- a/tests/specs/lint/node_globals_no_duplicate_imports/main.ts +++ b/tests/specs/lint/node_globals_no_duplicate_imports/main.ts @@ -1,7 +1,7 @@ import {} from "node:console"; -const _foo = process.env.FOO; +const _foo = setImmediate; import {} from "node:assert"; -const _bar = process.env.BAR; +const _bar = setImmediate; |