diff options
| author | Marvin Hagemeister <marvin@deno.com> | 2024-07-08 21:28:39 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-08 21:28:39 +0200 |
| commit | b338b541ac828113667fdd24c18db97d3e47c282 (patch) | |
| tree | 8906e1d917dc5cd5af331a3c9be651820743899c /tests | |
| parent | 86010bec092d074b161800da06149cfb79fb9f4b (diff) | |
fix(node/assert): throws not checking error instance (#24466)
The implementation for `assert.throws()` from `node:assert` didn't work
when the expected value was an `Error` constructor. In this case the
thrown error should checked if it's an instance of said constructor.
Fixes https://github.com/denoland/deno/issues/24464
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/integration/node_unit_tests.rs | 1 | ||||
| -rw-r--r-- | tests/unit_node/assert_test.ts | 18 |
2 files changed, 19 insertions, 0 deletions
diff --git a/tests/integration/node_unit_tests.rs b/tests/integration/node_unit_tests.rs index 15d2021c1..4f0b61378 100644 --- a/tests/integration/node_unit_tests.rs +++ b/tests/integration/node_unit_tests.rs @@ -53,6 +53,7 @@ util::unit_test_factory!( _fs_writeFile_test = _fs / _fs_writeFile_test, _fs_write_test = _fs / _fs_write_test, async_hooks_test, + assert_test, assertion_error_test, buffer_test, child_process_test, diff --git a/tests/unit_node/assert_test.ts b/tests/unit_node/assert_test.ts new file mode 100644 index 000000000..dc565458f --- /dev/null +++ b/tests/unit_node/assert_test.ts @@ -0,0 +1,18 @@ +// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license. +import * as assert from "node:assert"; + +Deno.test("[node/assert] .throws() compares Error instance", () => { + assert.throws( + () => { + throw new Error("FAIL"); + }, + Error, + ); + + assert.throws( + () => { + throw new TypeError("FAIL"); + }, + TypeError, + ); +}); |
