diff options
| author | Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> | 2024-06-06 14:21:25 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-06 21:21:25 +0000 |
| commit | 47d19461a59cc7997f24987d8564e757683b8a5e (patch) | |
| tree | 814753ce96999e37016b0ed74edfcf138e1fc5ec /tests | |
| parent | 0648f6d70dc79e986f6b3c5821a9ebb5f045cfc7 (diff) | |
fix(cli): Overwrite existing bin entries in `node_modules` (#24123)
Previously we warned on unix and didn't touch them on windows, now we
unconditionally overwrite them. This matches what npm does.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/specs/task/bin_package/__test__.jsonc | 5 | ||||
| -rw-r--r-- | tests/specs/task/bin_package/already-set-up.out | 9 |
2 files changed, 2 insertions, 12 deletions
diff --git a/tests/specs/task/bin_package/__test__.jsonc b/tests/specs/task/bin_package/__test__.jsonc index 19bad633e..d5da4b4e1 100644 --- a/tests/specs/task/bin_package/__test__.jsonc +++ b/tests/specs/task/bin_package/__test__.jsonc @@ -27,17 +27,16 @@ } ] }, - "warns_if_already_setup": { + "clobbers_if_already_setup": { "tempDir": true, "steps": [{ - "if": "unix", "commandName": "npm", "args": "install", "output": "\nadded 1 package in [WILDCARD]\n" }, { "if": "unix", "args": "task sayhi", - "output": "already-set-up.out" + "output": "task.out" }] } } diff --git a/tests/specs/task/bin_package/already-set-up.out b/tests/specs/task/bin_package/already-set-up.out deleted file mode 100644 index 336459daa..000000000 --- a/tests/specs/task/bin_package/already-set-up.out +++ /dev/null @@ -1,9 +0,0 @@ -Download http://localhost:4260/@denotest/bin -Download http://localhost:4260/@denotest/bin/1.0.0.tgz -Initialize @denotest/bin@1.0.0 -Warning Trying to set up [WILDCARD] bin for [WILDCARD], but an entry pointing to [WILDCARD] already exists. Skipping... -Warning Trying to set up [WILDCARD] bin for [WILDCARD] but an entry pointing to [WILDCARD] already exists. Skipping... -Warning Trying to set up [WILDCARD] bin for [WILDCARD], but an entry pointing to [WILDCARD] already exists. Skipping... -Task sayhi cli-esm hi hello -hi -hello |