diff options
author | Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> | 2024-07-09 20:06:08 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-07-10 03:06:08 +0000 |
commit | ce7dc2be92499f15b4b0315bfca3ee9d61fc3c5e (patch) | |
tree | f2463a8026d6f68d288c04b8671ce26f310de9fe /tests/util | |
parent | eb46296e974c686896486350bb00bf428a84e9fd (diff) |
feat(node): Support executing npm package lifecycle scripts (preinstall/install/postinstall) (#24487)
Adds support for running npm package lifecycle scripts, opted into via a
new `--allow-scripts` flag.
With this PR, when running `deno cache` (or `DENO_FUTURE=1 deno
install`) you can specify the `--allow-scripts=pkg1,pkg2` flag to run
lifecycle scripts attached to the given packages.
Note at the moment this only works when `nodeModulesDir` is true (using
the local resolver).
When a package with un-run lifecycle scripts is encountered, we emit a
warning suggesting things may not work and to try running lifecycle
scripts. Additionally, if a package script implicitly requires
`node-gyp` and it's not found on the system, we emit a warning.
Extra things in this PR:
- Extracted out bits of `task.rs` into a separate module for reuse
- Added a couple fields to `process.config` in order to support
`node-gyp` (it relies on a few variables being there)
- Drive by fix to downloading new npm packages to test registry
---
TODO:
- [x] validation for allow-scripts args (make sure it looks like an npm
package)
- [x] make allow-scripts matching smarter
- [ ] figure out what issues this closes
---
Review notes:
- This adds a bunch of deps to our test registry due to using
`node-gyp`, so it's pretty noisy
Diffstat (limited to 'tests/util')
-rw-r--r-- | tests/util/server/src/npm.rs | 7 | ||||
-rw-r--r-- | tests/util/server/src/servers/npm_registry.rs | 1 |
2 files changed, 7 insertions, 1 deletions
diff --git a/tests/util/server/src/npm.rs b/tests/util/server/src/npm.rs index e7d8d96ab..f1c341738 100644 --- a/tests/util/server/src/npm.rs +++ b/tests/util/server/src/npm.rs @@ -110,7 +110,12 @@ impl TestNpmRegistry { } pub fn package_url(&self, package_name: &str) -> String { - format!("http://{}/{}/", self.hostname, package_name) + let scheme = if self.hostname.starts_with("http://") { + "" + } else { + "http://" + }; + format!("{}{}/{}/", scheme, self.hostname, package_name) } fn get_package_property<TResult>( diff --git a/tests/util/server/src/servers/npm_registry.rs b/tests/util/server/src/servers/npm_registry.rs index 7e5547b5b..f19fa5d92 100644 --- a/tests/util/server/src/servers/npm_registry.rs +++ b/tests/util/server/src/servers/npm_registry.rs @@ -297,6 +297,7 @@ async fn download_npm_registry_file( testdata_file_path: &PathBuf, is_tarball: bool, ) -> Result<(), anyhow::Error> { + let uri_path = uri_path.trim_start_matches('/'); let url_parts = uri_path.split('/').collect::<Vec<_>>(); let package_name = if url_parts[0].starts_with('@') { url_parts.into_iter().take(2).collect::<Vec<_>>().join("/") |