summaryrefslogtreecommitdiff
path: root/tests/unit_node/http_test.ts
diff options
context:
space:
mode:
authorLuca Casonato <hello@lcas.dev>2024-08-12 12:01:37 +0200
committerGitHub <noreply@github.com>2024-08-12 12:01:37 +0200
commit56e8ed5eb1a6f2880c96fc8f08e35a6dd83aad8b (patch)
tree7db167c2ea0e925a1a0c3a6ec8b1bdcdfa2126ba /tests/unit_node/http_test.ts
parent004b74c8c65a492a15a7538f71d44a92a86675fa (diff)
fix(ext/node): don't concat set-cookie in ServerResponse.appendHeader (#25000)
Follow-on to https://github.com/denoland/deno/pull/24216/files#r1642188672
Diffstat (limited to 'tests/unit_node/http_test.ts')
-rw-r--r--tests/unit_node/http_test.ts21
1 files changed, 21 insertions, 0 deletions
diff --git a/tests/unit_node/http_test.ts b/tests/unit_node/http_test.ts
index 3d53e09f9..c0514eebd 100644
--- a/tests/unit_node/http_test.ts
+++ b/tests/unit_node/http_test.ts
@@ -1118,6 +1118,27 @@ Deno.test("[node/http] ServerResponse appendHeader", async () => {
await promise;
});
+Deno.test("[node/http] ServerResponse appendHeader set-cookie", async () => {
+ const { promise, resolve } = Promise.withResolvers<void>();
+ const server = http.createServer((_req, res) => {
+ res.appendHeader("Set-Cookie", "a=b");
+ res.appendHeader("Set-Cookie", "c=d");
+ res.end("Hello World");
+ });
+
+ server.listen(async () => {
+ const { port } = server.address() as { port: number };
+ const res = await fetch(`http://localhost:${port}`);
+ assertEquals(res.headers.getSetCookie(), ["a=b", "c=d"]);
+ assertEquals(await res.text(), "Hello World");
+ server.close(() => {
+ resolve();
+ });
+ });
+
+ await promise;
+});
+
Deno.test("[node/http] IncomingMessage override", () => {
const req = new http.IncomingMessage(new net.Socket());
// https://github.com/dougmoscrop/serverless-http/blob/3aaa6d0fe241109a8752efb011c242d249f32368/lib/request.js#L20-L30