summaryrefslogtreecommitdiff
path: root/tests/unit_node/http_test.ts
diff options
context:
space:
mode:
authorNathan Whitaker <17734409+nathanwhit@users.noreply.github.com>2024-10-16 17:42:15 -0700
committerGitHub <noreply@github.com>2024-10-17 00:42:15 +0000
commit458d6278d2835896018086da773fd72b7af8ed66 (patch)
treed8b5708d49c7d68cf51682b95a56d9710d01df6c /tests/unit_node/http_test.ts
parent3385d1252e4eae093234d0a075f4a564308ba48e (diff)
fix(node/http): normalize header names in `ServerResponse` (#26339)
Fixes https://github.com/denoland/deno/issues/26115. We weren't normalizing the headers to lower case, so code that attempted to delete the `Content-Length` header (but used a different case) wasn't actually removing the header.
Diffstat (limited to 'tests/unit_node/http_test.ts')
-rw-r--r--tests/unit_node/http_test.ts28
1 files changed, 28 insertions, 0 deletions
diff --git a/tests/unit_node/http_test.ts b/tests/unit_node/http_test.ts
index f1ff77bb3..0faf7fb34 100644
--- a/tests/unit_node/http_test.ts
+++ b/tests/unit_node/http_test.ts
@@ -1147,6 +1147,34 @@ Deno.test("[node/http] ServerResponse appendHeader set-cookie", async () => {
await promise;
});
+Deno.test("[node/http] ServerResponse header names case insensitive", async () => {
+ const { promise, resolve } = Promise.withResolvers<void>();
+ const server = http.createServer((_req, res) => {
+ res.setHeader("Content-Length", "12345");
+ res.removeHeader("content-length");
+ assertEquals(res.getHeader("Content-Length"), undefined);
+ assert(!res.hasHeader("Content-Length"));
+ res.appendHeader("content-length", "12345");
+ res.removeHeader("Content-Length");
+ assertEquals(res.getHeader("content-length"), undefined);
+ assert(!res.hasHeader("content-length"));
+ res.end("Hello World");
+ });
+
+ server.listen(async () => {
+ const { port } = server.address() as { port: number };
+ const res = await fetch(`http://localhost:${port}`);
+ assertEquals(res.headers.get("Content-Length"), null);
+ assertEquals(res.headers.get("content-length"), null);
+ assertEquals(await res.text(), "Hello World");
+ server.close(() => {
+ resolve();
+ });
+ });
+
+ await promise;
+});
+
Deno.test("[node/http] IncomingMessage override", () => {
const req = new http.IncomingMessage(new net.Socket());
// https://github.com/dougmoscrop/serverless-http/blob/3aaa6d0fe241109a8752efb011c242d249f32368/lib/request.js#L20-L30