diff options
| author | Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> | 2024-08-28 13:42:42 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-28 13:42:42 -0700 |
| commit | 37501aa32357e75b9ddc92198da94d92fcdd0798 (patch) | |
| tree | f87a09bbe351ebe29b0c1b4fff4dca5b4f066ced /tests/unit_node/_fs/_fs_fsync_test.ts | |
| parent | 6ccaebcdeae95a82b270ac5bde78b65b37fadb45 (diff) | |
fix(napi): Don't run microtasks in napi_resolve_deferred (#25246)
Fixes an incredibly obscure bug that causes parcel's file watcher to not
get any file update notifications on macOS.
The issue was that the native addon was calling `napi_resolve_deferred`,
but when we resolved the promise, v8 was running microtasks
automatically. That executed JS, which called back into the native addon
and broke the addon's assumption that the call wouldn't be reentrant.
Diffstat (limited to 'tests/unit_node/_fs/_fs_fsync_test.ts')
0 files changed, 0 insertions, 0 deletions