BREAKING(types): soft-remove `Deno.run()` (#25403)

Towards #22079

2 files changed, 38 insertions, 39 deletions

diff --git a/tests/unit/http_test.ts b/tests/unit/http_test.ts
index 6d3543e44..778cc98fd 100644
--- a/tests/unit/http_test.ts
+++ b/tests/unit/http_test.ts
@@ -2087,7 +2087,6 @@ Deno.test({
     async function client() {
       const url = `http://${hostname}:${port}/`;
       const cmd = [
-        "curl",
         "-i",
         "--request",
         "GET",
@@ -2097,16 +2096,17 @@ Deno.test({
         "--header",
         "Accept-Encoding: deflate, gzip",
       ];
-      const proc = Deno.run({ cmd, stdout: "piped", stderr: "null" });
-      const status = await proc.status();
-      assert(status.success);
-      const output = decoder.decode(await proc.output());
+      const { success, stdout } = await new Deno.Command("curl", {
+        args: cmd,
+        stderr: "null",
+      }).output();
+      assert(success);
+      const output = decoder.decode(stdout);
       assert(output.includes("vary: Accept-Encoding\r\n"));
       assert(output.includes("content-encoding: gzip\r\n"));
       // Ensure the content-length header is updated.
       assert(!output.includes(`content-length: ${contentLength}\r\n`));
       assert(output.includes("content-length: "));
-      proc.close();
     }
 
     await Promise.all([server(), client()]);
@@ -2149,7 +2149,6 @@ Deno.test({
     async function client() {
       const url = `http://${hostname}:${port}/`;
       const cmd = [
-        "curl",
         "-i",
         "--request",
         "GET",
@@ -2159,13 +2158,15 @@ Deno.test({
         "--header",
         "Accept-Encoding: deflate, gzip",
       ];
-      const proc = Deno.run({ cmd, stdout: "piped", stderr: "null" });
-      const status = await proc.status();
-      assert(status.success);
-      const output = decoder.decode(await proc.output());
+      const { success, stdout } = await new Deno.Command("curl", {
+        args: cmd,
+        stderr: "null",
+        stdout: "piped",
+      }).output();
+      assert(success);
+      const output = decoder.decode(stdout);
       assert(output.includes("vary: Accept-Encoding\r\n"));
       assert(output.includes("content-encoding: arbitrary\r\n"));
-      proc.close();
     }
 
     await Promise.all([server(), client()]);
diff --git a/tests/unit/process_test.ts b/tests/unit/process_test.ts
index 383f17f38..0d14c9ce7 100644
--- a/tests/unit/process_test.ts
+++ b/tests/unit/process_test.ts
@@ -1,3 +1,4 @@
+// deno-lint-ignore-file no-deprecated-deno-api
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
 import {
   assert,
@@ -12,7 +13,7 @@ Deno.test(
   { permissions: { read: true, run: false } },
   function runPermissions() {
     assertThrows(() => {
-      // deno-lint-ignore no-deprecated-deno-api
+      // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
       Deno.run({
         cmd: [Deno.execPath(), "eval", "console.log('hello world')"],
       });
@@ -23,7 +24,7 @@ Deno.test(
 Deno.test(
   { permissions: { run: true, read: true } },
   async function runSuccess() {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       // freeze the array to ensure it's not modified
       cmd: Object.freeze([
@@ -46,7 +47,7 @@ Deno.test(
 Deno.test(
   { permissions: { run: true, read: true } },
   async function runUrl() {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [
         new URL(`file:///${Deno.execPath()}`),
@@ -70,7 +71,7 @@ Deno.test(
   async function runStdinRid0(): Promise<
     void
   > {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [Deno.execPath(), "eval", "console.log('hello world')"],
       stdin: 0,
@@ -90,26 +91,23 @@ Deno.test(
   { permissions: { run: true, read: true } },
   function runInvalidStdio() {
     assertThrows(() =>
-      // deno-lint-ignore no-deprecated-deno-api
+      // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
       Deno.run({
         cmd: [Deno.execPath(), "eval", "console.log('hello world')"],
-        // @ts-expect-error because Deno.run should throw on invalid stdin.
         stdin: "a",
       })
     );
     assertThrows(() =>
-      // deno-lint-ignore no-deprecated-deno-api
+      // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
       Deno.run({
         cmd: [Deno.execPath(), "eval", "console.log('hello world')"],
-        // @ts-expect-error because Deno.run should throw on invalid stdout.
         stdout: "b",
       })
     );
     assertThrows(() =>
-      // deno-lint-ignore no-deprecated-deno-api
+      // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
       Deno.run({
         cmd: [Deno.execPath(), "eval", "console.log('hello world')"],
-        // @ts-expect-error because Deno.run should throw on invalid stderr.
         stderr: "c",
       })
     );
@@ -119,7 +117,7 @@ Deno.test(
 Deno.test(
   { permissions: { run: true, read: true } },
   async function runCommandFailedWithCode() {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [Deno.execPath(), "eval", "Deno.exit(41 + 1)"],
     });
@@ -136,7 +134,7 @@ Deno.test(
     permissions: { run: true, read: true },
   },
   async function runCommandFailedWithSignal() {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [
         Deno.execPath(),
@@ -160,7 +158,7 @@ Deno.test(
 Deno.test({ permissions: { run: true } }, function runNotFound() {
   let error;
   try {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     Deno.run({ cmd: ["this file hopefully doesn't exist"] });
   } catch (e) {
     error = e;
@@ -192,7 +190,7 @@ tryExit();
 `;
 
     Deno.writeFileSync(`${cwd}/${programFile}`, enc.encode(program));
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cwd,
       cmd: [Deno.execPath(), "run", "--allow-read", programFile],
@@ -216,7 +214,7 @@ Deno.test(
   async function runStdinPiped(): Promise<
     void
   > {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [
         Deno.execPath(),
@@ -254,7 +252,7 @@ Deno.test(
   async function runStdoutPiped(): Promise<
     void
   > {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [
         Deno.execPath(),
@@ -291,7 +289,7 @@ Deno.test(
   async function runStderrPiped(): Promise<
     void
   > {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [
         Deno.execPath(),
@@ -326,7 +324,7 @@ Deno.test(
 Deno.test(
   { permissions: { run: true, read: true } },
   async function runOutput() {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [
         Deno.execPath(),
@@ -347,7 +345,7 @@ Deno.test(
   async function runStderrOutput(): Promise<
     void
   > {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [
         Deno.execPath(),
@@ -377,7 +375,7 @@ Deno.test(
       write: true,
     });
 
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [
         Deno.execPath(),
@@ -414,7 +412,7 @@ Deno.test(
     await Deno.writeTextFile(fileName, "hello");
     using file = await Deno.open(fileName);
 
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [
         Deno.execPath(),
@@ -439,7 +437,7 @@ Deno.test(
 Deno.test(
   { permissions: { run: true, read: true } },
   async function runEnv() {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [
         Deno.execPath(),
@@ -462,7 +460,7 @@ Deno.test(
 Deno.test(
   { permissions: { run: true, read: true } },
   async function runClose() {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [
         Deno.execPath(),
@@ -486,7 +484,7 @@ Deno.test(
 Deno.test(
   { permissions: { run: true, read: true } },
   async function runKillAfterStatus() {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [Deno.execPath(), "eval", 'console.log("hello")'],
     });
@@ -543,7 +541,7 @@ Deno.test(
 Deno.test(
   { permissions: { run: true, read: true } },
   async function killSuccess() {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [Deno.execPath(), "eval", "setTimeout(() => {}, 10000)"],
     });
@@ -567,7 +565,7 @@ Deno.test(
 );
 
 Deno.test({ permissions: { run: true, read: true } }, function killFailed() {
-  // deno-lint-ignore no-deprecated-deno-api
+  // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
   const p = Deno.run({
     cmd: [Deno.execPath(), "eval", "setTimeout(() => {}, 10000)"],
   });
@@ -588,7 +586,7 @@ Deno.test(
     ignore: Deno.build.os === "windows",
   },
   async function non_existent_cwd(): Promise<void> {
-    // deno-lint-ignore no-deprecated-deno-api
+    // @ts-ignore `Deno.run()` was soft-removed in Deno 2.
     const p = Deno.run({
       cmd: [
         Deno.execPath(),