summaryrefslogtreecommitdiff
path: root/tests/specs
diff options
context:
space:
mode:
authorDavid Sherret <dsherret@users.noreply.github.com>2024-10-04 08:52:00 +0100
committerGitHub <noreply@github.com>2024-10-04 07:52:00 +0000
commitedac9166040dc09674072ce57af6a9c5ea958d85 (patch)
tree0a54e2946b8d6146e3620b4859c6d609d1c657ee /tests/specs
parentb8a9a4a862e4d61630c5bc8089261c7a177ec97a (diff)
fix(install): surface package.json dependency errors (#26023)
Diffstat (limited to 'tests/specs')
-rw-r--r--tests/specs/run/package_json/invalid_value/__test__.jsonc46
-rw-r--r--tests/specs/run/package_json/invalid_value/add.out8
-rw-r--r--tests/specs/run/package_json/invalid_value/install.out10
-rw-r--r--tests/specs/run/package_json/invalid_value/task.out3
4 files changed, 29 insertions, 38 deletions
diff --git a/tests/specs/run/package_json/invalid_value/__test__.jsonc b/tests/specs/run/package_json/invalid_value/__test__.jsonc
index 0b3c63384..195734d95 100644
--- a/tests/specs/run/package_json/invalid_value/__test__.jsonc
+++ b/tests/specs/run/package_json/invalid_value/__test__.jsonc
@@ -6,49 +6,25 @@
"args": "run --quiet --node-modules-dir=auto ok.ts",
"output": "ok.ts.out"
},
- "run_ok_byonm": {
- "steps": [
- {
- "args": "install",
- "output": "install.out"
- },
- {
- "args": "run ok.ts",
- "output": "ok.ts.out"
- }
- ]
- },
// should fail when referencing a failing dep entry
"run_error_auto": {
"args": "run --node-modules-dir=auto error.ts",
"exitCode": 1,
"output": "error_auto.out"
},
- "run_error_byonm": {
- "steps": [
- {
- "args": "install",
- "output": "install.out"
- },
- {
- "args": "run error.ts",
- "exitCode": 1,
- "output": "error.out"
- }
- ]
+ "install_error_byonm": {
+ "args": "install",
+ "output": "install.out",
+ "exitCode": 1
+ },
+ "add_error_byonm": {
+ "args": "add npm:cowsay",
+ "output": "add.out",
+ "exitCode": 1
},
- // should output a warning about the failing dep entry
"task_test": {
- "steps": [
- {
- "args": "install",
- "output": "install.out"
- },
- {
- "args": "task test",
- "output": "task.out"
- }
- ]
+ "args": "task --node-modules-dir=auto test",
+ "output": "task.out"
}
}
}
diff --git a/tests/specs/run/package_json/invalid_value/add.out b/tests/specs/run/package_json/invalid_value/add.out
new file mode 100644
index 000000000..9b7493c1a
--- /dev/null
+++ b/tests/specs/run/package_json/invalid_value/add.out
@@ -0,0 +1,8 @@
+Add npm:cowsay@1.5.0
+error: Failed to install from package.json
+
+Caused by:
+ 0: Invalid version requirement
+ 1: Unexpected character.
+ invalid stuff that won't parse
+ ~
diff --git a/tests/specs/run/package_json/invalid_value/install.out b/tests/specs/run/package_json/invalid_value/install.out
index b8114c12a..cc82b345b 100644
--- a/tests/specs/run/package_json/invalid_value/install.out
+++ b/tests/specs/run/package_json/invalid_value/install.out
@@ -1,3 +1,7 @@
-Download http://localhost:4260/@denotest/esm-basic
-Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
-Initialize @denotest/esm-basic@1.0.0
+error: Failed to install from package.json
+
+Caused by:
+ 0: Invalid version requirement
+ 1: Unexpected character.
+ invalid stuff that won't parse
+ ~
diff --git a/tests/specs/run/package_json/invalid_value/task.out b/tests/specs/run/package_json/invalid_value/task.out
index 79249d175..d0adb0525 100644
--- a/tests/specs/run/package_json/invalid_value/task.out
+++ b/tests/specs/run/package_json/invalid_value/task.out
@@ -1,2 +1,5 @@
+Download http://localhost:4260/@denotest/esm-basic
+Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
+Initialize @denotest/esm-basic@1.0.0
Task test echo 1
1