diff options
| author | Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> | 2024-07-09 20:06:08 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-10 03:06:08 +0000 |
| commit | ce7dc2be92499f15b4b0315bfca3ee9d61fc3c5e (patch) | |
| tree | f2463a8026d6f68d288c04b8671ce26f310de9fe /tests/specs/npm/lifecycle_scripts/node_gyp_not_found.out | |
| parent | eb46296e974c686896486350bb00bf428a84e9fd (diff) | |
feat(node): Support executing npm package lifecycle scripts (preinstall/install/postinstall) (#24487)
Adds support for running npm package lifecycle scripts, opted into via a
new `--allow-scripts` flag.
With this PR, when running `deno cache` (or `DENO_FUTURE=1 deno
install`) you can specify the `--allow-scripts=pkg1,pkg2` flag to run
lifecycle scripts attached to the given packages.
Note at the moment this only works when `nodeModulesDir` is true (using
the local resolver).
When a package with un-run lifecycle scripts is encountered, we emit a
warning suggesting things may not work and to try running lifecycle
scripts. Additionally, if a package script implicitly requires
`node-gyp` and it's not found on the system, we emit a warning.
Extra things in this PR:
- Extracted out bits of `task.rs` into a separate module for reuse
- Added a couple fields to `process.config` in order to support
`node-gyp` (it relies on a few variables being there)
- Drive by fix to downloading new npm packages to test registry
---
TODO:
- [x] validation for allow-scripts args (make sure it looks like an npm
package)
- [x] make allow-scripts matching smarter
- [ ] figure out what issues this closes
---
Review notes:
- This adds a bunch of deps to our test registry due to using
`node-gyp`, so it's pretty noisy
Diffstat (limited to 'tests/specs/npm/lifecycle_scripts/node_gyp_not_found.out')
| -rw-r--r-- | tests/specs/npm/lifecycle_scripts/node_gyp_not_found.out | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/tests/specs/npm/lifecycle_scripts/node_gyp_not_found.out b/tests/specs/npm/lifecycle_scripts/node_gyp_not_found.out new file mode 100644 index 000000000..65ea53d58 --- /dev/null +++ b/tests/specs/npm/lifecycle_scripts/node_gyp_not_found.out @@ -0,0 +1,8 @@ +[UNORDERED_START] +Download http://localhost:4260/@denotest/node-addon-implicit-node-gyp +Download http://localhost:4260/@denotest/node-addon-implicit-node-gyp/1.0.0.tgz +Initialize @denotest/node-addon-implicit-node-gyp@1.0.0 +[UNORDERED_END] +warning: node-gyp was used in a script, but was not listed as a dependency. Either add it as a dependency or install it globally (e.g. `npm install -g node-gyp`) +[WILDCARD] +error: script 'install' in '@denotest/node-addon-implicit-node-gyp@1.0.0' failed with exit code 1 |