diff options
| author | Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> | 2024-10-23 21:13:30 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-10-23 21:13:30 -0700 |
| commit | 7c57105cc41cf16c5f48f85d85c7fd9bd3bb4d1f (patch) | |
| tree | 3263cc60139b71b340c93e988128d8ce5aca6e6f /tests/specs/node/child_process_extra_pipes/main.out | |
| parent | fa49fd404be82daf8ac7228bf54e780135f67b17 (diff) | |
fix(ext/node): only set our end of child process pipe to nonblocking mode (#26495)
Fixes playwright on linux, as reported in
https://github.com/denoland/deno/issues/16899#issuecomment-2378268454.
The issue was that we were opening the socket in nonblocking mode, which
meant that subprocesses trying to use it would get a `EWOULDBLOCK` error
(unexpectedly). The fix here is to only set nonblocking mode on our end
(which we need to use asynchronously)
Diffstat (limited to 'tests/specs/node/child_process_extra_pipes/main.out')
| -rw-r--r-- | tests/specs/node/child_process_extra_pipes/main.out | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/specs/node/child_process_extra_pipes/main.out b/tests/specs/node/child_process_extra_pipes/main.out index 694126b92..436afd2f7 100644 --- a/tests/specs/node/child_process_extra_pipes/main.out +++ b/tests/specs/node/child_process_extra_pipes/main.out @@ -1,5 +1,5 @@ -data: hello world [UNORDERED_START] child closed +got: hello world pipe closed [UNORDERED_END] |