diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2024-09-09 16:19:29 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-09 20:19:29 +0000 |
| commit | 72f025c74320ffd6df9758ac53c74db68e0a3e10 (patch) | |
| tree | b7c72a6055cbd13bedcc0132af0c1f96342858ea /tests/specs/install/alias_invalid_path_char | |
| parent | 1e0ac609b57b9efdafd54de4cb56f98c507c032f (diff) | |
fix: remove recently added deno.json node_modules aliasing (#25542)
This was initially added in #25399 in order to make transitioning over
from package.json to deno.json more easy, but it causes some problems
that are shown in the issue and it also means that the output of `deno
install` would have different resolution than `npm install`. Overall, I
think it's too much complexity to be smarter about this and it's
probably best to not do it. If someone needs an aliased folder then they
should keep using a package.json
Closes #25538
Diffstat (limited to 'tests/specs/install/alias_invalid_path_char')
4 files changed, 0 insertions, 29 deletions
diff --git a/tests/specs/install/alias_invalid_path_char/__test__.jsonc b/tests/specs/install/alias_invalid_path_char/__test__.jsonc deleted file mode 100644 index 4a3058635..000000000 --- a/tests/specs/install/alias_invalid_path_char/__test__.jsonc +++ /dev/null @@ -1,10 +0,0 @@ -{ - "tempDir": true, - "steps": [{ - "args": "install", - "output": "[WILDCARD]" - }, { - "args": "run --allow-read=. verify.ts", - "output": ".bin\n.deno\n@denotest\n" - }] -} diff --git a/tests/specs/install/alias_invalid_path_char/deno.jsonc b/tests/specs/install/alias_invalid_path_char/deno.jsonc deleted file mode 100644 index 85befb55e..000000000 --- a/tests/specs/install/alias_invalid_path_char/deno.jsonc +++ /dev/null @@ -1,7 +0,0 @@ -{ - "imports": { - // alias*test is an invalid path char on windows, so - // don't create an alias for this - "alias*test": "npm:@denotest/add" - } -} diff --git a/tests/specs/install/alias_invalid_path_char/package.json b/tests/specs/install/alias_invalid_path_char/package.json deleted file mode 100644 index 2c63c0851..000000000 --- a/tests/specs/install/alias_invalid_path_char/package.json +++ /dev/null @@ -1,2 +0,0 @@ -{ -} diff --git a/tests/specs/install/alias_invalid_path_char/verify.ts b/tests/specs/install/alias_invalid_path_char/verify.ts deleted file mode 100644 index 497e1d8dd..000000000 --- a/tests/specs/install/alias_invalid_path_char/verify.ts +++ /dev/null @@ -1,10 +0,0 @@ -const entries = Array.from( - Deno.readDirSync(new URL("./node_modules", import.meta.url)), -); -const names = entries.map((entry) => entry.name); -names.sort(); - -// won't have the invalid path alias -for (const name of names) { - console.log(name); -} |