feat: vm rewrite (#24596)

rewrite vm implementation to increase compat.
vm.Module+importModuleDynamically callbacks should be added in a
followup.

1 files changed, 101 insertions, 0 deletions

diff --git a/tests/node_compat/test/parallel/test-vm-options-validation.js b/tests/node_compat/test/parallel/test-vm-options-validation.js
new file mode 100644
index 000000000..d1b215ed7
--- /dev/null
+++ b/tests/node_compat/test/parallel/test-vm-options-validation.js
@@ -0,0 +1,101 @@
+// deno-fmt-ignore-file
+// deno-lint-ignore-file
+
+// Copyright Joyent and Node contributors. All rights reserved. MIT license.
+// Taken from Node 18.12.1
+// This file is automatically generated by `tests/node_compat/runner/setup.ts`. Do not modify this file manually.
+
+'use strict';
+
+require('../common');
+const assert = require('assert');
+const vm = require('vm');
+
+const invalidArgType = {
+  name: 'TypeError',
+  code: 'ERR_INVALID_ARG_TYPE'
+};
+
+const outOfRange = {
+  name: 'RangeError',
+  code: 'ERR_OUT_OF_RANGE'
+};
+
+assert.throws(() => {
+  new vm.Script('void 0', 42);
+}, invalidArgType);
+
+[null, {}, [1], 'bad', true].forEach((value) => {
+  assert.throws(() => {
+    new vm.Script('void 0', { lineOffset: value });
+  }, invalidArgType);
+
+  assert.throws(() => {
+    new vm.Script('void 0', { columnOffset: value });
+  }, invalidArgType);
+});
+
+[0.1, 2 ** 32].forEach((value) => {
+  assert.throws(() => {
+    new vm.Script('void 0', { lineOffset: value });
+  }, outOfRange);
+
+  assert.throws(() => {
+    new vm.Script('void 0', { columnOffset: value });
+  }, outOfRange);
+});
+
+assert.throws(() => {
+  new vm.Script('void 0', { lineOffset: Number.MAX_SAFE_INTEGER });
+}, outOfRange);
+
+assert.throws(() => {
+  new vm.Script('void 0', { columnOffset: Number.MAX_SAFE_INTEGER });
+}, outOfRange);
+
+assert.throws(() => {
+  new vm.Script('void 0', { filename: 123 });
+}, invalidArgType);
+
+assert.throws(() => {
+  new vm.Script('void 0', { produceCachedData: 1 });
+}, invalidArgType);
+
+[[0], {}, true, 'bad', 42].forEach((value) => {
+  assert.throws(() => {
+    new vm.Script('void 0', { cachedData: value });
+  }, invalidArgType);
+});
+
+{
+  const script = new vm.Script('void 0');
+  const sandbox = vm.createContext();
+
+  function assertErrors(options, errCheck) {
+    assert.throws(() => {
+      script.runInThisContext(options);
+    }, errCheck);
+
+    assert.throws(() => {
+      script.runInContext(sandbox, options);
+    }, errCheck);
+
+    assert.throws(() => {
+      script.runInNewContext({}, options);
+    }, errCheck);
+  }
+
+  [null, 'bad', 42].forEach((value) => {
+    assertErrors(value, invalidArgType);
+  });
+  [{}, [1], 'bad', null].forEach((value) => {
+    assertErrors({ timeout: value }, invalidArgType);
+  });
+  [-1, 0, NaN].forEach((value) => {
+    assertErrors({ timeout: value }, outOfRange);
+  });
+  [{}, [1], 'bad', 1, null].forEach((value) => {
+    assertErrors({ displayErrors: value }, invalidArgType);
+    assertErrors({ breakOnSigint: value }, invalidArgType);
+  });
+}